Create custom rouge theme#3267
Merged
marcphilipp merged 5 commits intojunit-team:mainfrom May 6, 2023
Bukama:asciidoctheme
Merged
Create custom rouge theme#3267marcphilipp merged 5 commits intojunit-team:mainfrom Bukama:asciidoctheme
marcphilipp merged 5 commits intojunit-team:mainfrom
Bukama:asciidoctheme
Conversation
Member
Contributor
Author
hmm. And I thought it was for |
Member
|
@Bukama We'd like to include this PR in the upcoming 5.10-M1 release. Do you have time to make the changes requested in #3071 (comment) until mid next week? |
Contributor
Author
|
Removed the dark theme, based on team decision in the linked issue and turned the draft PR into a regular PR. Proposed commit message. |
marcphilipp
approved these changes
May 6, 2023
Member
|
@Bukama Thanks for your perseverance in getting this addressed! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @marcphilipp asked me to push my try for a custom asciidoc theme (see #3071 ):
What I tried first was chaning the default theme to one of the other build-in themes, e.g.
colorful.This was done easy, as you only have to change the
index.adocand add the:rouge-style: colorfultag, run the gradle task "asciidoc" and the colorful theme is applied.It doesn't matter if you set the attribute in the
documentation.gradle.ktsfile - set settings in this file are not picked up anyway.I then tried to create an own theme, by starting to just take the example from the asciidoc example, and just chaning some colors to blue, to make them visual and to see that the theme is picked up. I also added the file to the copy ressources list (
documentation.gradle.kts) as the guide says you have to do so.It turns out that the file is copies to
build\docs\asciidoc\resources\themes\but it does not get picked up, even I figured out that the pure existence of the file, regardless if the new added file / theme is mentioned anyway breaks the theme usage. So even when thecolorfultheme is set, the guide is rendered in default theme. The name / location of the theme file or the theme doesn't change anything about this behavior.I also tried to run Gradle with "--debug" (as described in the IntelliJ Gradle Debug docs), but no debug information were written.
Well and this whole situation is what blows my mind since hours.
What you see in the PR is that the added file breaks the theme usage. Only thing that works with the current state of this PR is the copying of the file due
include("resources/themes/rogue_junit.rb")in the Gradle-file. If you comment out those and remove the theme file, you will see that the setting to colorful is used again.