refactor: replace console.warn with process.emitWarning#954
Merged
RyanZim merged 1 commit intojprichardson:masterfrom Apr 16, 2022
lamweili:refactor/warning-mechanism
Merged
refactor: replace console.warn with process.emitWarning#954RyanZim merged 1 commit intojprichardson:masterfrom lamweili:refactor/warning-mechanism
RyanZim merged 1 commit intojprichardson:masterfrom
lamweili:refactor/warning-mechanism
Conversation
Signed-off-by: Lam Wei Li <peteriman@mail.com>
Collaborator
|
Should we consider this: https://nodejs.org/api/process.html#avoiding-duplicate-warnings? |
Contributor
Author
|
My motivation was to retain the behavior of the Should we change it to use https://nodejs.org/api/process.html#avoiding-duplicate-warnings instead, so it only warns on the first time? What do you guy think? Let me know and I'll make the adjustments. 😊 |
JPeer264
approved these changes
Apr 9, 2022
Collaborator
JPeer264
left a comment
There was a problem hiding this comment.
I am fine with either. Thanks for the changes and your efforts :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To have consistent warnings from #953 (comment) by @JPeer264
Prints out via
process.emitWarningin the following format: