Skip to content

Fix bug with inline snapshots when snapshot is string not template literal#14465

Merged
SimenB merged 2 commits intojestjs:mainfrom
bawjensen:inline-snapshot-template-literal-fix
Sep 5, 2023
Merged

Fix bug with inline snapshots when snapshot is string not template literal#14465
SimenB merged 2 commits intojestjs:mainfrom
bawjensen:inline-snapshot-template-literal-fix

Conversation

@bawjensen
Copy link
Copy Markdown
Contributor

@bawjensen bawjensen commented Aug 31, 2023

Summary

Fixes #14464.

Please let me know what else I can do to flesh this PR out. I could quite well be overlooking something.

Test plan

Added a unit test.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Aug 31, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 31, 2023 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c9d2a5f
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64f11609628b3a0008c19dee
😎 Deploy Preview https://deploy-preview-14465--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SimenB
SimenB approved these changes Sep 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thanks!

@SimenB SimenB merged commit 5611a1d into jestjs:main Sep 5, 2023
@SimenB
Copy link
Copy Markdown
Member

SimenB commented Sep 12, 2023

https://github.com/jestjs/jest/releases/tag/v29.7.0

@bawjensen bawjensen deleted the inline-snapshot-template-literal-fix branch September 12, 2023 18:46
@bryan-codaio
Copy link
Copy Markdown

bryan-codaio commented Sep 12, 2023

tyvm for the quick turnaround and the notification that it's been released

@SimenB
Copy link
Copy Markdown
Member

SimenB commented Sep 12, 2023

All credits to @bawjensen for this, but happy to hear it helped you! 😀 most feedback I get are people complaining, so happy to see some people appreciate the work we all do 👍👍

@bawjensen
Copy link
Copy Markdown
Contributor Author

bawjensen commented Sep 12, 2023

ah @bryan-codaio is me posting from the wrong account 😅

I can relate to appreciating the positive feedback to offset the negative - most folks don't remember to mention the good moments (I almost forgot to follow up here after bumping the dependency version to 29.7.0), so I try to make a point of it

This was referenced Sep 17, 2023
Merged
Merged
@ms-bot ms-bot mentioned this pull request Oct 2, 2023
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 13, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Inline snapshots are appending a new template literal instead of replacing existing string

3 participants

@bawjensen @SimenB @bryan-codaio