Skip to content

Add isRISCV method to Platform class#1671

Merged
matthiasblaesing merged 1 commit intojava-native-access:masterfrom
Glavo:riscv
May 20, 2025
Merged

Add isRISCV method to Platform class#1671
matthiasblaesing merged 1 commit intojava-native-access:masterfrom
Glavo:riscv

Conversation

@Glavo
Copy link
Copy Markdown
Contributor

@Glavo Glavo commented May 20, 2025

No description provided.

@matthiasblaesing
Copy link
Copy Markdown
Member

Looks generally sensible to me. Please add an entry to the features section of the CHANGES.md, squash that change into the first entry and update the author name to your full name. Thank you.

@Glavo
Copy link
Copy Markdown
Contributor Author

Glavo commented May 20, 2025

Looks generally sensible to me. Please add an entry to the features section of the CHANGES.md, squash that change into the first entry and update the author name to your full name. Thank you.

Done.

@matthiasblaesing
Copy link
Copy Markdown
Member

Thank you for the update. Please squash the changes and fix the author name. This does not look like a full name.

@Glavo
Copy link
Copy Markdown
Contributor Author

Glavo commented May 20, 2025

I have squashed the commits.

My real name isn’t an English name, Glavo is the only English name I use.

@matthiasblaesing
Copy link
Copy Markdown
Member

@Glavo thanks for the update and explanation. Will start CI and if that comes back green, will merge.

@matthiasblaesing matthiasblaesing merged commit ec70f94 into java-native-access:master May 20, 2025
12 checks passed
@Glavo Glavo deleted the riscv branch May 20, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants