Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 930b662ea3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| async function run(): Promise<void> { | ||
| const inputs = getInputs() | ||
| core.info( | ||
| `Resolved action inputs: prek-version="${inputs.prekVersion}", install-only=${inputs.installOnly}, working-directory="${inputs.workingDirectory}"` |
There was a problem hiding this comment.
Sanitize user input before logging with core.info
run() now logs inputs.prekVersion and inputs.workingDirectory directly via core.info, which writes raw text to stdout; if a workflow passes untrusted or multiline values (for example from PR metadata), injected \n::...:: sequences can be interpreted by the runner as workflow commands instead of plain log text. This turns a debug log into a command-injection surface in CI contexts that propagate external input into action inputs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR adds additional action logging around prek version resolution, installation/download steps, and cache-dir resolution to make runs easier to troubleshoot.
Changes:
- Log chosen prek version and key action inputs (install-only, working directory).
- Add logs for manifest version/asset resolution and install workflow (asset selection, download/extract paths, checksum verification).
- Add logs for cache-dir discovery and fallback behavior.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/prek.ts | Logs resolved prek cache directory and fallback path. |
| src/manifest.ts | Adds @actions/core logging for version/asset resolution decisions. |
| src/main.ts | Logs resolved inputs, selected prek version, and install-only short-circuit. |
| src/install.ts | Logs selected release asset, download/extract/cache paths, and checksum verification. |
| dist/index.js | Updates bundled output to include new logging (but currently appears out of sync with src/ in places). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| core.info( | ||
| `Resolved action inputs: prek-version="${inputs.prekVersion}", install-only=${inputs.installOnly}, working-directory="${inputs.workingDirectory}"` | ||
| ) |
Summary
Testing