Skip to content

Move version manifest out of bundle#100

Merged
j178 merged 3 commits intomainfrom
codex/move-version-manifest
Mar 16, 2026
Merged

Move version manifest out of bundle#100
j178 merged 3 commits intomainfrom
codex/move-version-manifest

Conversation

@j178
Copy link
Copy Markdown
Owner

@j178 j178 commented Mar 16, 2026

Summary

  • move the version manifest to the repo root and fetch it from raw.githubusercontent.com at runtime
  • generate a separate known-checksums map keyed by version and asset name
  • update workflows, tests, and bundled output for the new manifest/checksum flow

Copilot AI review requested due to automatic review settings March 16, 2026 14:38
@j178 j178 added the enhancement New feature or request label Mar 16, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 345f359a06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/manifest.ts
Comment thread src/manifest.ts Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves prek version metadata out of the bundled action code by downloading a repo-root version-manifest.json at runtime, and introduces a separate generated checksum map to verify downloaded assets.

Changes:

  • Replace bundled manifest usage with runtime download/caching of version-manifest.json for version/asset resolution.
  • Introduce generated knownChecksumsByAsset keyed by version:assetName and update install-time checksum verification to use it.
  • Update updater script/workflow, tests, and types/docs to match the new manifest/checksum flow.

Reviewed changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/manifest.ts Downloads and caches the version manifest at runtime; updates version/asset resolution APIs.
src/install.ts Switches checksum verification to use a generated known-checksum map keyed by version+asset.
src/types.ts Simplifies ManifestAsset shape (removes checksum/size fields).
src/known-checksums.ts Adds generated checksum map for assets by version.
scripts/update-known-versions.mjs Generates repo-root manifest + checksum map; updates PR output metadata.
.github/workflows/update-known-versions.yml Updates scheduled workflow to regenerate new manifest/checksum outputs and open PRs.
test/manifest.test.ts Updates tests for new manifest-driven resolution APIs.
test/install.test.ts Updates checksum validation tests for the new checksum lookup scheme.
package.json Renames updater script to update-known-versions.
README.md Updates documentation references from bundled manifest to runtime resolution wording.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/manifest.ts
Comment thread src/manifest.ts Outdated
Comment thread test/install.test.ts Outdated
Comment thread test/install.test.ts
Comment thread test/install.test.ts Outdated
@j178 j178 force-pushed the codex/move-version-manifest branch from 345f359 to fea8b93 Compare March 16, 2026 14:56
@j178 j178 changed the base branch from v2 to main March 16, 2026 15:07
@j178 j178 closed this Mar 16, 2026
@j178 j178 reopened this Mar 16, 2026
@j178 j178 merged commit 02ce158 into main Mar 16, 2026
9 checks passed
@j178 j178 deleted the codex/move-version-manifest branch March 16, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants