Skip to content

Remove update-known-versions job#115

Merged
j178 merged 1 commit intomainfrom
j178-patch-1
Mar 23, 2026
Merged

Remove update-known-versions job#115
j178 merged 1 commit intomainfrom
j178-patch-1

Conversation

@j178
Copy link
Copy Markdown
Owner

@j178 j178 commented Mar 23, 2026

New versions will be published on prek releases, this job is no longer needed.

New versions will be published on `prek` releases, this job is no longer needed.
Copilot AI review requested due to automatic review settings March 23, 2026 09:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the scheduled GitHub Actions workflow that automatically refreshes this action’s prek version metadata and opens PRs with updated manifest/checksum/bundled outputs.

Changes:

  • Deletes the Update Known Versions workflow that periodically ran npm run update-known-versions and created PRs for updated version-manifest.json, src/known-checksums.ts, and dist/ bundles.
Comments suppressed due to low confidence (1)

.github/workflows/update-known-versions.yml:1

  • Deleting this workflow removes the only automated mechanism in this repo that refreshes version-manifest.json and src/known-checksums.ts from upstream j178/prek releases. The runtime code uses the manifest to resolve latest and semver ranges (and skips checksum verification when checksums are missing), so if these files aren’t updated elsewhere the action will lag behind new prek releases and may stop verifying new binaries. Consider adding an equivalent update step to the release workflow (or another automation) or changing runtime resolution to query releases directly so latest/ranges stay current.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a97ae550a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines -1 to -5
name: Update Known Versions

on:
schedule:
- cron: '17 3 * * *'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep a workflow that refreshes known prek versions

Removing this workflow leaves the repository with no in-repo automation that runs npm run update-known-versions (checked remaining workflow files: ci.yml, release.yml, zizmor.yml), so version-manifest.json/src/known-checksums.ts will stop tracking new prek releases unless someone updates them manually elsewhere. That breaks the action’s documented default behavior over time because latest and semver ranges are resolved from the manifest (src/manifest.ts), and newer exact versions lose checksum verification when their entries are missing (src/install.ts).

Useful? React with 👍 / 👎.

@j178 j178 added the internal label Mar 23, 2026
@j178 j178 merged commit 53276d8 into main Mar 23, 2026
13 checks passed
@j178 j178 deleted the j178-patch-1 branch March 23, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants