fix: cannot resolve the ast messages which has json path for v9#2162
Merged
fix: cannot resolve the ast messages which has json path for v9#2162
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/core-base/src/resolver.ts:354
- The early return here may prematurely stop the resolution while traversing AST keys. Consider revisiting this logic to ensure it doesn't mask valid values when keys match AST_NODE_PROPS_KEYS.
if (AST_NODE_PROPS_KEYS.includes(key) && isMessageAST(last)) {
packages/core-base/test/translate.test.ts:995
- [nitpick] The test for JSON path keys is currently skipped. Consider adding a comment clarifying the conditions for enabling this test to ensure it is revisited when the fix is verified.
test.skip('json path key', () => {
Deploying vue-i18n-next with
|
| Latest commit: |
21d08f9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b0d7b829.vue-i18n-next.pages.dev |
| Branch Preview URL: | https://fix-resolve-ast-message-v9.vue-i18n-next.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #2156