Merged
Conversation
SimY4
commented
Dec 13, 2025
| <profile> | ||
| <id>errorprone</id> | ||
| <activation> | ||
| <jdk>[1.8,23)</jdk> |
Contributor
Author
There was a problem hiding this comment.
error prone now only applied on JDK range: from 1.8 to 23.
SimY4
commented
Dec 13, 2025
| </activation> | ||
|
|
||
| <properties> | ||
| <maven.compiler.proc>full</maven.compiler.proc> |
Contributor
Author
There was a problem hiding this comment.
proc full is now very important. Nothing works without it.
SimY4
commented
Dec 13, 2025
|
|
||
| <properties> | ||
| <maven.compiler.proc>full</maven.compiler.proc> | ||
| <maven.compiler.release>8</maven.compiler.release> |
Contributor
Author
There was a problem hiding this comment.
Starting from some JDK version release flag is now required as well.
SimY4
commented
Dec 13, 2025
| <id>jdk16-errorprone</id> | ||
| <activation> | ||
| <jdk>[16,)</jdk> | ||
| <jdk>[16,23)</jdk> |
Contributor
Author
There was a problem hiding this comment.
Same, error prone up to 23.
Member
|
Thank you! Seems only new, good stuff added! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable immutable compilation on JDK 23+
All the learnings from this work:
Since Java 23 unless specified explicitly in
<annotationProcessor>configuration section annotation processors won't be located on classpath and executed without providing-proc:fullcompiler flag. This change was made in JDK 23.error prone can't compile JDK 25 target without an upgrade. But upgrade brings backward incompatible changes to error prone configuration. So I've disable error prone for JDK targets beyond JDK 23. Once immutables will bump minimum supported JDK version, error prone can be updated and enabled again for JDKs past 23.
ecj compiler is not running annotation processors. I recon the issue is similar to
-proc:fullflag in my point 1 in findings, except I have no clue how to provide this toecj. I tried to look up any info on that, no luck. So I've excludedecjfrom build matrix until I can figure out how to bring it back.