GH-1557: Fix erroneous code generation for TypeTokens of raw annotated types#1558
Merged
elucash merged 1 commit intoimmutables:masterfrom Jul 6, 2025
Merged
GH-1557: Fix erroneous code generation for TypeTokens of raw annotated types#1558elucash merged 1 commit intoimmutables:masterfrom
elucash merged 1 commit intoimmutables:masterfrom
Conversation
…w annotated types
Member
|
yes, it should be |
Member
|
thank you, merging |
Contributor
Author
|
@elucash hey, do you happen to know when the next release is likely to drop with this included in it? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-1557, where the use of documented annotations such as those in JSpecify resulted in the type representation including annotation names. This resulted in invalid code being generated for
TypeToken.of($TYPE$.class)as the output would erroneously becomeTypeToken.of(@SomeAnnotationHere $TYPE$.class), which is invalid Java syntax.