Skip to content

Fix a bug with type annotation handling#1532

Merged
elucash merged 1 commit intoimmutables:masterfrom
cushon:type-annotations
Jan 17, 2025
Merged

Fix a bug with type annotation handling#1532
elucash merged 1 commit intoimmutables:masterfrom
cushon:type-annotations

Conversation

@cushon
Copy link
Copy Markdown
Contributor

@cushon cushon commented Jan 15, 2025

See #1531

@cushon
Copy link
Copy Markdown
Contributor Author

cushon commented Jan 15, 2025

Suggestions for a better place to put test coverage for this are welcome.

@sdeleuze
Copy link
Copy Markdown

+1 from the Spring team for this fix.

@elucash
Copy link
Copy Markdown
Member

elucash commented Jan 17, 2025

Thank you for the PR! Got it, I guess the test might be enough (i.e. just not break in the presence of a type annotation)

@elucash elucash merged commit 51cea97 into immutables:master Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants