Skip to content

Bug with Jackson unshading #1561

@Dolvic

Description

@Dolvic

Hi

From what I can tell, an unintended bug was introduced with the changes to unshade Jackson.

On this line, it seems that it should be '.annotation.JsonCreator.Mode' instead of 'annotation.JsonCreator.Mode'. Specifically the missing . at the beginning. There are 3 other similar instances of jackson in the file, and all of them have the string beginning with a .. From what I can tell, this makes Immutables check if the class com.fasterxml.jacksonannotation.JsonCreator.Mode (or a shaded version with a different prefix) is available on the classpath, which ends up always failing and so the Mode.DELEGATING part is never added to the definition of the fromJson method.

In absence of Mode.DELEGATING, if the Jackson ObjectMapper is configured to use property names (via their PropertyNamesModule), it causes the deserialization to fail at this point.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions