Skip to content

[ci] Fixing some failing tests for important models#43231

Merged
remi-or merged 7 commits intohuggingface:mainfrom
Abdennacer-Badaoui:fix-amd-failures
Jan 14, 2026
Merged

[ci] Fixing some failing tests for important models#43231
remi-or merged 7 commits intohuggingface:mainfrom
Abdennacer-Badaoui:fix-amd-failures

Conversation

@Abdennacer-Badaoui
Copy link
Copy Markdown
Member

@Abdennacer-Badaoui Abdennacer-Badaoui commented Jan 12, 2026

This PR addresses several failing tests in the CI.


Fixed tests :

  • tests/models/gpt2/test_modeling_gpt2.py::GPT2ModelLanguageGenerationTest::test_batch_generation
  • tests/models/gpt2/test_modeling_gpt2.py::GPT2ModelLanguageGenerationTest::test_batch_generation_2heads
  • tests/models/detr/test_modeling_detr.py::DetrModelIntegrationTests::test_inference_no_head
  • tests/models/llama/test_tokenization_llama.py::LlamaTokenizationTest::test_added_tokens_serialization
  • tests/models/llama/test_tokenization_llama.py:LlamaTokenizationTest:test_chat_template_return_assistant_tokens_mask
  • tests/models/llama/test_tokenization_llama.py::LlamaTokenizationTest::test_chat_template_return_assistant_tokens_mask_truncated
  • tests/models/llama/test_tokenization_llama.py::LlamaTokenizationTest::test_padding_side_in_kwargs
  • tests/models/llama/test_tokenization_llama.py::LlamaTokenizationTest::test_truncation_side_in_kwargs
  • tests/models/llava/test_modeling_llava.py::LlavaForConditionalGenerationIntegrationTest::test_tokenizer_integration
  • tests/models/qwen2_5_omni/test_modeling_qwen2_5_omni.py::Qwen2_5OmniModelIntegrationTest::test_small_model_integration_test_batch

@Abdennacer-Badaoui Abdennacer-Badaoui marked this pull request as draft January 12, 2026 11:12
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: detr, gpt2, llava, qwen2_5_omni

@Abdennacer-Badaoui
Copy link
Copy Markdown
Member Author

Removed the @require_read_token decorator, as a smoother process is coming in #43233

@Abdennacer-Badaoui Abdennacer-Badaoui marked this pull request as ready for review January 13, 2026 09:11
@github-actions github-actions Bot requested a review from ydshieh January 13, 2026 09:11
Copy link
Copy Markdown
Collaborator

@remi-or remi-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I will un slow tests before merging to double check. I left 2 comments to address, thanks!

Comment thread tests/models/detr/test_modeling_detr.py
Comment thread tests/models/gpt2/test_modeling_gpt2.py
@remi-or
Copy link
Copy Markdown
Collaborator

remi-or commented Jan 14, 2026

run-slow: detr, gpt2, llava

@github-actions
Copy link
Copy Markdown
Contributor

This comment contains run-slow, running the specified jobs:

models: ["models/detr", "models/gpt2", "models/llava"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

✅ No failing test specific to this PR 🎉 !

@remi-or remi-or merged commit d1808f2 into huggingface:main Jan 14, 2026
21 checks passed
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Jan 23, 2026
* fix gpt2 tests

* use_safetensors=False for facebook/detr-resnet-50

* use @require_read_token decorator for LlamaTokenizationTest

* update an expected_output

* style

* fix an expectation

* remove @require_read_token decorator, smoother process is coming in huggingface#43233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants