fix(utils/mime): Normalize input extension to lowercase before MIME check#4800
Merged
yusukebe merged 1 commit intohonojs:mainfrom Mar 11, 2026
Merged
fix(utils/mime): Normalize input extension to lowercase before MIME check#4800yusukebe merged 1 commit intohonojs:mainfrom
yusukebe merged 1 commit intohonojs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4800 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 177 177
Lines 11633 11633
Branches 3465 3464 -1
=======================================
Hits 10799 10799
Misses 833 833
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@TheEssem Thanks! Good fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a filename with an upper/mixed-case extension is provided to getMimeType, it currently returns an undefined value which causes the static middleware to return a Content-Type of
application/octet-stream. This PR normalizes upper/mixed-case file extensions during the check so that they can be properly matched to the MIME type map.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code