grpc-js: Fix a crash when grpc.keepalive_permit_without_calls is set#2519
Merged
murgatroid99 merged 1 commit intogrpc:@grpc/grpc-js@1.8.xfrom Jul 25, 2023
Merged
Conversation
gnossen
approved these changes
Jul 25, 2023
alexander-joinlane
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the change in #2513 added a trace line to starting the keepalive timer. That can be called from the constructor if the option
grpc.keepalive_permit_without_callsis set, and that fails because the object isn't fully constructed. This change just rearranges the constructor so that the parts of the setup that affect trace logs are completed as early as possible, and starting the keepalive timer happens as late as possible.