grpc-js: Fix bugs in pick first LB policy and channel subchannel wrapper#2369
Merged
murgatroid99 merged 1 commit intogrpc:@grpc/grpc-js@1.8.xfrom Feb 22, 2023
Merged
Conversation
gnossen
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2368. The change in #2363 caused the pick first LB policy to own
SubchannelWrapperobjects as opposed toSubchannelobjects for a first time. This triggered a bug that existed since the introduction of subchannel wrappers, where the LB policy would perform an equality test between two subchannel interface objects without handling the case where one is a wrapper. The calls togetRealSubchannelfix that. This bug was not previously triggered because the only previousSubchannelWrapperimplementation was for the outlier detection LB policy, and it makes no sense to use that LB policy with pick first.In addition, testing this also revealed an older bug that has existed since the introduction of
SubchannelAddressobjects. The LB policy currently performs a naive equality check between two of them, which is always false.Finally, the
ChannelSubchannelWrapperclass's subchannel connectivity state listener was written as though calls toaddConnectivityStateListenerandremoveConnectivityStateListenerwould be intercepted, but they are not, so I removed that code and added code to remove that listener when the wrapper is discarded.