Skip to content

xds: xDS-based HTTP CONNECT configuration#11861

Merged
shivaspeaks merged 10 commits intogrpc:masterfrom
shivaspeaks:xds_http_connect
Mar 6, 2025
Merged

xds: xDS-based HTTP CONNECT configuration#11861
shivaspeaks merged 10 commits intogrpc:masterfrom
shivaspeaks:xds_http_connect

Conversation

@shivaspeaks
Copy link
Copy Markdown
Member

@shivaspeaks shivaspeaks commented Jan 29, 2025 •
edited
Loading

@shivaspeaks shivaspeaks requested a review from ejona86 January 29, 2025 13:40
ejona86
ejona86 reviewed Jan 29, 2025
View reviewed changes
Comment thread xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsClusterResource.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsClusterResource.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsClusterResource.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsEndpointResource.java Outdated
@shivaspeaks shivaspeaks requested a review from ejona86 January 30, 2025 19:30
ejona86
ejona86 reviewed Jan 30, 2025
View reviewed changes
Comment thread xds/src/main/java/io/grpc/xds/XdsEndpointResource.java
Comment thread xds/src/main/java/io/grpc/xds/XdsEndpointResource.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsEndpointResource.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsClusterResource.java Outdated
@shivaspeaks shivaspeaks requested a review from ejona86 February 1, 2025 01:56
ejona86
ejona86 reviewed Feb 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there's a TODO in the comment, but I'm OOO tomorrow so I might at least share what meager comments I have. You can wait until I finisher the fuller review.

Comment thread xds/src/main/java/io/grpc/xds/XdsEndpointResource.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsEndpointResource.java Outdated
ejona86
ejona86 reviewed Feb 12, 2025
View reviewed changes
Comment thread xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsEndpointResource.java Outdated
@shivaspeaks shivaspeaks requested a review from ejona86 February 17, 2025 10:33
@shivaspeaks
Copy link
Copy Markdown
Member Author

shivaspeaks commented Feb 17, 2025

Please react on this comment (👍) if this looks good, and then I will proceed with unit tests. Except the class cast discussion.

@ejona86 ejona86 removed their request for review February 26, 2025 00:40
@shivaspeaks shivaspeaks requested a review from ejona86 March 3, 2025 13:32
ejona86
ejona86 reviewed Mar 4, 2025
View reviewed changes
Comment thread xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsClusterResource.java
Comment thread xds/src/main/java/io/grpc/xds/XdsClusterResource.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/MetadataRegistry.java Outdated
Comment thread xds/src/test/java/io/grpc/xds/GrpcXdsClientImplDataTest.java Outdated
Comment thread xds/src/test/java/io/grpc/xds/GrpcXdsClientImplDataTest.java Outdated
Comment thread xds/src/test/java/io/grpc/xds/ClusterResolverLoadBalancerTest.java Outdated
Comment thread xds/src/test/java/io/grpc/xds/ClusterResolverLoadBalancerTest.java Outdated
Comment thread xds/src/test/java/io/grpc/xds/ClusterResolverLoadBalancerTest.java Outdated
@shivaspeaks shivaspeaks requested a review from ejona86 March 5, 2025 18:19
ejona86
ejona86 reviewed Mar 5, 2025
View reviewed changes
Comment thread xds/src/test/java/io/grpc/xds/ClusterResolverLoadBalancerTest.java Outdated
Comment thread xds/src/test/java/io/grpc/xds/GrpcXdsClientImplDataTest.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/MetadataRegistry.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsEndpointResource.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java Outdated
@shivaspeaks shivaspeaks merged commit 1219706 into grpc:master Mar 6, 2025
@shivaspeaks shivaspeaks deleted the xds_http_connect branch March 6, 2025 08:19
@shivaspeaks shivaspeaks mentioned this pull request May 24, 2025
Merged
shivaspeaks added a commit to shivaspeaks/grpc-java that referenced this pull request May 24, 2025
@shivaspeaks
xds: xDS-based HTTP CONNECT configuration (grpc#11861)
45323f7
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shivaspeaks @ejona86