Merged
Conversation
…grpc#8997) Summary of changes: - Add a new API to the `balancergroup` that allows removal of child policies with immediate effect, even when a cache is configured. - Make the `priority` LB use this new API when removing child policies that have been removed from its configuration. - This change is protected with an environment variable that turns on the new behavior by default. - Update the name generation algorithm to give higher preference to reuse names of existing priority (if there is a locality match) over lower priorities. - Fix a bunch of tests in the `priority` LB policy to ensure that they work with the *old* and *new* behavior. - Fix a couple of aggregate cluster tests such that they don't continuously handle the same NACKed resource from the management server. - Other minor cleanups in tests that I had to look at as part of making this change. RELEASE NOTES: * xds/priority: Stop caching child LB policies removed from the configuration. This will help reduce memory and cpu usage when localities are constantly switching between priorities.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v1.80.x #9027 +/- ##
===========================================
- Coverage 82.45% 82.16% -0.29%
===========================================
Files 410 410
Lines 32601 32628 +27
===========================================
- Hits 26880 26809 -71
- Misses 4051 4080 +29
- Partials 1670 1739 +69
🚀 New features to boost your workflow:
|
Contributor
|
The title and description seem to mention the wrong PR. I'll try to fix them before approving the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #8997
RELEASE NOTES: