gracefulswitch: Wait for all goroutines on close#8746
Merged
eshitachandwani merged 1 commit intogrpc:masterfrom Dec 11, 2025
Merged
Conversation
Goroutines spawned during balancer swaps could outlive the call to Balancer.Close(). Monitor these via a wait group and wait for them to finish before returning from Close(). This prevents any noticeable side effects that could otherwise occur after Close() returns. RELEASE NOTES: - Closing a graceful switch balancer will now block until all pending goroutines complete. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8746 +/- ##
==========================================
- Coverage 83.38% 83.30% -0.08%
==========================================
Files 418 418
Lines 32367 32371 +4
==========================================
- Hits 26988 26968 -20
+ Misses 4014 4011 -3
- Partials 1365 1392 +27
🚀 New features to boost your workflow:
|
easwars
approved these changes
Dec 10, 2025
eshitachandwani
approved these changes
Dec 11, 2025
This was referenced Apr 23, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goroutines spawned during balancer swaps could outlive the call to Balancer.Close(). Monitor these via a wait group and wait for them to finish before returning from Close(). This prevents any noticeable side effects that could otherwise occur after Close() returns.
See:
RELEASE NOTES: