examples/opentelemetry: demonstrate enabling experimental metrics#8388
Merged
arjan-bal merged 5 commits intogrpc:masterfrom Jun 23, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8388 +/- ##
==========================================
- Coverage 82.33% 82.31% -0.03%
==========================================
Files 413 413
Lines 40454 40430 -24
==========================================
- Hits 33307 33278 -29
+ Misses 5782 5779 -3
- Partials 1365 1373 +8 🚀 New features to boost your workflow:
|
arjan-bal
reviewed
Jun 16, 2025
arjan-bal
reviewed
Jun 18, 2025
Contributor
|
Please merge the latest master branch to unblock the PR Validation test. |
Contributor
|
The merge is not performed correctly. The PR diff is showing all the commits that were merged. Can you please reset and do a regular |
0243437 to
e5de1e2
Compare
Contributor
Author
|
@arjan-bal I force-pushed after merging the latest master, and it seems the branch got closed automatically. Can you able to open this branch. |
Contributor
|
There are 0 commits on the PR, so it can't be re-opened. If you can bring back the commits on this branch, I should be able to re-open it. |
0ea97fb to
db6900c
Compare
db6900c to
5143e0d
Compare
5143e0d to
d2e8366
Compare
arjan-bal
reviewed
Jun 20, 2025
Comment on lines
+65
to
+67
| // These are example experimental gRPC metrics, which are disabled by default | ||
| // and must be explicitly enabled. For the full, up-to-date list of metrics, | ||
| // see: https://grpc.io/docs/guides/opentelemetry-metrics/#instruments |
Contributor
There was a problem hiding this comment.
Please move these comments to the line just above Metrics: .
arjan-bal
approved these changes
Jun 23, 2025
purnesh42H
reviewed
Jun 23, 2025
| // up-to-date list of metrics, see: | ||
| // https://grpc.io/docs/guides/opentelemetry-metrics/#instruments | ||
| Metrics: opentelemetry.DefaultMetrics().Add( | ||
| "grpc.server.call.started", |
Contributor
There was a problem hiding this comment.
why are we adding these in default? These are already part of default metric set
grpc-go/stats/opentelemetry/opentelemetry.go
Line 443 in bdbe6a2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8311
RELEASE NOTES: