encoding: delete v1 proto codec and use one map for registry#7557
Merged
dfawley merged 3 commits intogrpc:masterfrom Aug 23, 2024
Merged
encoding: delete v1 proto codec and use one map for registry#7557dfawley merged 3 commits intogrpc:masterfrom
dfawley merged 3 commits intogrpc:masterfrom
Conversation
arvindbr8
approved these changes
Aug 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7557 +/- ##
==========================================
- Coverage 81.79% 81.71% -0.09%
==========================================
Files 362 361 -1
Lines 27832 27816 -16
==========================================
- Hits 22765 22729 -36
- Misses 3856 3875 +19
- Partials 1211 1212 +1
|
dfawley
added a commit
to dfawley/grpc-go
that referenced
this pull request
Aug 26, 2024
dfawley
added a commit
that referenced
this pull request
Aug 26, 2024
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @PapaCharlie
Without this change, existing users that overwrote the v1
"proto"codec with special changes will have a behavior change, as we will choose the v2"proto"codec over theirs. Also there seems to be little value to keeping the v1 proto codec around since we would never use it.RELEASE NOTES: none