Skip to content

Cherry-pick #6856 to v1.60.x release branch#6864

Merged
easwars merged 1 commit intogrpc:v1.60.xfrom
easwars:cherrypick_6856
Dec 18, 2023
Merged

Cherry-pick #6856 to v1.60.x release branch#6864
easwars merged 1 commit intogrpc:v1.60.xfrom
easwars:cherrypick_6856

Conversation

@easwars
Copy link
Copy Markdown
Contributor

@easwars easwars commented Dec 18, 2023

RELEASE NOTES:

  • server: fix two bugs that could lead to panics at shutdown when using NumStreamWorkers (experimental feature).

@easwars easwars requested a review from zasweq December 18, 2023 19:04
@easwars easwars added this to the 1.61 Release milestone Dec 18, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 18, 2023

Codecov Report

Merging #6864 (abfad18) into v1.60.x (6430548) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.60.x    #6864      +/-   ##
===========================================
+ Coverage    83.67%   83.76%   +0.08%     
===========================================
  Files          286      286              
  Lines        30792    30797       +5     
===========================================
+ Hits         25765    25796      +31     
+ Misses        3974     3948      -26     
  Partials      1053     1053              
Files Coverage Δ
server.go 81.45% <100.00%> (+2.45%) ⬆️

... and 23 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@easwars easwars merged commit 6e384cf into grpc:v1.60.x Dec 18, 2023
@easwars easwars deleted the cherrypick_6856 branch December 18, 2023 19:35
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants