Skip to content

Enable wrapper-validation by default in setup-gradle#318

Merged
bigdaz merged 6 commits intomainfrom
dd/snapshot-wrapper-checksums
Aug 1, 2024
Merged

Enable wrapper-validation by default in setup-gradle#318
bigdaz merged 6 commits intomainfrom
dd/snapshot-wrapper-checksums

Conversation

@bigdaz
Copy link
Copy Markdown
Member

@bigdaz bigdaz commented Jul 31, 2024

No description provided.

bigdaz added 2 commits July 31, 2024 21:26
By slurping the checksum URLs from https://services.gradle.org/distributions-snapshots/
we can include these unpublished wrapper checksums in validation.

Fixes #281
@bigdaz bigdaz force-pushed the dd/snapshot-wrapper-checksums branch 2 times, most recently from a6997f7 to 4ee7c4c Compare August 1, 2024 04:03
bigdaz added 3 commits August 1, 2024 10:51
- Add 'allow-snapshot-wrappers' input parameter
- Default 'validate-wrappers' to 'true'

Fixes #12
The most common case for validation will be that the wrapper jars are unchanged
from a previous workflow run. In this case, we cache the validated wrapper
checksums to minimise the work required on a subsequent run.

Fixes #172
@bigdaz bigdaz force-pushed the dd/snapshot-wrapper-checksums branch from 9334ab3 to 2e52c98 Compare August 1, 2024 16:58
@bigdaz bigdaz force-pushed the dd/snapshot-wrapper-checksums branch from 2e52c98 to 73f1290 Compare August 1, 2024 16:59
@bigdaz bigdaz changed the title Include wrapper checksums for Gradle nightlies and other snapshots Enable wrapper-validation by default in setup-gradle Aug 1, 2024
@bigdaz bigdaz merged commit 06905c7 into main Aug 1, 2024
@bigdaz bigdaz deleted the dd/snapshot-wrapper-checksums branch August 1, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant