Skip to content

feat: add changelog-host input to action.yml#948

Merged
chingor13 merged 2 commits into
googleapis:mainfrom
eliw00d:main
Mar 11, 2024
Merged

feat: add changelog-host input to action.yml#948
chingor13 merged 2 commits into
googleapis:mainfrom
eliw00d:main

Conversation

@eliw00d
Copy link
Copy Markdown
Contributor

@eliw00d eliw00d commented Feb 27, 2024

This was originally part of 3.3.0 (and fixed in 3.4.1 to default to github.server_url). However, it was not part of 4.0.0.

Without this input, you have to provide both config and manifest files in order to set the changelog-host option.

With this input, you can simply provide release-type and changelog-host without the need for config and manifest files. Also, since it defaults to github.server_url, most users will not even have to set it.

* Update index.ts

Signed-off-by: Paavo Bennett <paavobennettis@gmail.com>

* Update index.ts

Signed-off-by: Paavo Bennett <paavobennettis@gmail.com>

* Update index.ts

Signed-off-by: Paavo Bennett <paavobennettis@gmail.com>

* Update action.yml

Signed-off-by: Paavo Bennett <paavobennettis@gmail.com>

* Update index.ts

Signed-off-by: Paavo Bennett <paavobennettis@gmail.com>

---------

Signed-off-by: Paavo Bennett <paavobennettis@gmail.com>
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Feb 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dtanner
Copy link
Copy Markdown

dtanner commented Feb 27, 2024

➕ this would be awesome to have - our tens of thousands of repos on GHES now require additional configuration.

@chingor13 chingor13 merged commit 863b06f into googleapis:main Mar 11, 2024
chingor13 added a commit that referenced this pull request Mar 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.1.0](google-github-actions/release-please-action@v4.0.3...v4.1.0)
(2024-03-11)


### Features

* add `changelog-host` input to `action.yml`
([#948](https://github.com/google-github-actions/release-please-action/issues/948))
([863b06f](google-github-actions/release-please-action@863b06f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Jeff Ching <chingor@google.com>
This was referenced Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants