This repository was archived by the owner on Mar 3, 2026. It is now read-only.
perf: Improve Multiple Chunk Upload Performance#2185
Merged
Conversation
danielduhh
reviewed
Apr 26, 2023
Contributor
danielduhh
left a comment
There was a problem hiding this comment.
This looks like a significant change to the resumable write path. I suggest a design with some background information & comprehensive performance tests before merging this
ddelgrosso1
reviewed
Apr 27, 2023
Contributor
|
Overall I think this looks good and since we walked through the code I understand the why/how. I think once the supporting document is a bit more fleshed out with some metrics, I am good with this getting merged / released. |
ddelgrosso1
approved these changes
May 8, 2023
Contributor
ddelgrosso1
left a comment
There was a problem hiding this comment.
Going to approve this pending the results of perf tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chunkSizeuploads should be much faster. 🦕