This repository was archived by the owner on Mar 4, 2026. It is now read-only.
chore: Make compile with NodeJS v20.5.0#1906
Merged
gcf-merge-on-green[bot] merged 3 commits intomainfrom Sep 26, 2023
Merged
Conversation
dconeybe
approved these changes
Sep 26, 2023
| // https://github.com/DefinitelyTyped/DefinitelyTyped/pull/66176/files#diff-e838d0ace9cd5f6516bacfbd3ad00d02cd37bd60f9993ce6223f52d889a1fdbaR122-R126 | ||
| // | ||
| // Adding `[Symbol.dispose](): void;` cannot be done on older versions of | ||
| // NodeJS. So we simply cast to `NodeJS.Timout`. |
Contributor
There was a problem hiding this comment.
nit: Spelling error: Timout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An external change to CI appears to run code on NodeJS v20.5.0.
Unfortunately, this breaks our hacky override of Timeout. So as a quick fix, I made it even hackier. Since we only use this for tests, this should be fine.