Skip to content

fix(skill): fix env variable propagation#2645

Merged
helloeve merged 2 commits intomainfrom
skill-envpassing
Mar 10, 2026
Merged

fix(skill): fix env variable propagation#2645
helloeve merged 2 commits intomainfrom
skill-envpassing

Conversation

@helloeve
Copy link
Copy Markdown
Contributor

@helloeve helloeve commented Mar 5, 2026 •
edited
Loading

This PR refactors the tool file parsing logic by introducing a new ToolsFileParser struct. This encapsulation allows for stateful parsing, specifically enabling the tracking of resolved environment variables during configuration loading. This is useful for skill generation, where we can now identify and omit default values that correspond to environment variables, ensuring more precise generated skill.

@helloeve helloeve requested a review from a team as a code owner March 5, 2026 19:26
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Mar 5, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the internal mechanism for parsing tool configuration files. By introducing a dedicated ToolsFileParser struct, the parsing logic is now more modular and controllable. The primary benefit of this change is the ability to selectively disable environment variable interpolation during parsing, which is crucial for scenarios where the raw YAML structure needs to be read without immediate expansion of environment variables, particularly for skill generation. This enhances flexibility and precision in how tool configurations are processed.

Highlights

  • Encapsulated Tool File Parsing: Introduced a new ToolsFileParser struct to centralize and encapsulate the logic for parsing tool configuration files.
  • Controlled Environment Variable Interpolation: Added a SkipEnvParsing flag to the ToolsFileParser struct, allowing callers to explicitly control whether environment variables are interpolated during the parsing process.
  • Refactored Parsing Functions: Converted previously standalone parsing functions (parseToolsFile, LoadAndMergeToolsFiles, LoadAndMergeToolsFolder) into methods of the new ToolsFileParser struct.
  • Updated Call Sites: Modified all relevant call sites across the codebase to utilize the new ToolsFileParser struct when loading and parsing tool configuration files.
  • Unexported Helper Function: Renamed the ProcessValue helper function to processValue, making it unexported to align with Go's best practices for internal utility functions.
  • New Test Coverage: Added new unit tests specifically to verify the functionality of skipping environment variable replacement during tool file parsing.
Changelog
  • cmd/internal/invoke/command.go
    • Updated the LoadConfig function call to pass an instance of internal.ToolsFileParser{}.
  • cmd/internal/options.go
    • Modified the LoadConfig method signature to accept a ToolsFileParser parameter.
    • Updated internal calls to parsing functions (parseToolsFile, LoadAndMergeToolsFiles, LoadAndMergeToolsFolder) to use the provided ToolsFileParser instance.
  • cmd/internal/skills/command.go
    • Updated the LoadConfig function call to pass an instance of internal.ToolsFileParser{}.
  • cmd/internal/tools_file.go
    • Defined the ToolsFileParser struct, including a SkipEnvParsing boolean field.
    • Converted parseToolsFile into the ParseToolsFile method of ToolsFileParser, incorporating the SkipEnvParsing logic.
    • Converted LoadAndMergeToolsFiles into a method of ToolsFileParser.
    • Converted LoadAndMergeToolsFolder into a method of ToolsFileParser.
    • Renamed the exported ProcessValue function to the unexported processValue.
  • cmd/internal/tools_file_test.go
    • Modified existing test cases for parseToolsFile to instantiate and use ToolsFileParser.
    • Added a new TestSkipEnvVarReplacement function to validate the functionality of skipping environment variable replacement.
  • cmd/root.go
    • Updated calls to internal.LoadAndMergeToolsFolder, internal.LoadAndMergeToolsFiles, and opts.LoadConfig to instantiate and pass internal.ToolsFileParser{}.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@helloeve helloeve assigned averikitsch and twishabansal and unassigned Yuan325 Mar 5, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a ToolsFileParser to control environment variable parsing, which is a good approach for handling different parsing needs like skill generation. The implementation is clean and the new functionality is well-tested. The identified issue regarding the SkipEnvParsing flag not being correctly applied in the skills-generate command remains valid and should be addressed as detailed in the specific comment.

Comment thread cmd/internal/skills/command.go Outdated
twishabansal
twishabansal approved these changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@twishabansal twishabansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

averikitsch
averikitsch reviewed Mar 6, 2026
View reviewed changes
Comment thread cmd/root.go Outdated
@helloeve helloeve enabled auto-merge (squash) March 6, 2026 20:47
@helloeve helloeve disabled auto-merge March 6, 2026 20:47
@helloeve helloeve added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 6, 2026
@helloeve helloeve removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 7, 2026
@helloeve helloeve merged commit 5271368 into main Mar 10, 2026
19 checks passed
@helloeve helloeve deleted the skill-envpassing branch March 10, 2026 00:28
@release-please release-please Bot mentioned this pull request Mar 10, 2026
Merged
dumians pushed a commit to dumians/genai-toolbox that referenced this pull request Mar 12, 2026
@helloeve @dumians
fix(skill): fix env variable propagation (googleapis#2645)
37c72ca 
This PR refactors the tool file parsing logic by introducing a new
ToolsFileParser struct. This encapsulation allows for stateful parsing,
specifically enabling the tracking of resolved environment variables
during configuration loading. This is useful for skill generation, where
we can now identify and omit default values that correspond to
environment variables, ensuring more precise generated skill.
Yuan325 added a commit that referenced this pull request Mar 13, 2026
@release-please @Yuan325
chore(main): release 0.29.0 (#2608)
39832a0 
🤖 I have created a release *beep* *boop*
---


##
[0.29.0](v0.28.0...v0.29.0)
(2026-03-13)


### ⚠ BREAKING CHANGES

* **source/alloydb:** restructure prebuilt toolsets
([#2639](#2639))
* **source/spanner:** restructure prebuilt toolsets
([#2641](#2641))
* **source/dataplex:** restructure prebuilt toolsets
([#2640](#2640))
* **source/oss-db:** restructure prebuilt toolsets
([#2638](#2638))
* **source/cloudsql:** restructure prebuilt toolsets
([#2635](#2635))
* **source/bigquery:** restructure prebuilt toolsets
([#2637](#2637))
* **source/firestore:** restructure prebuilt toolsets
([#2636](#2636))
* telemetry metrics updates as per semantic convention
([#2566](#2566))

### Features

* Add user agent to embeddings generation
([#2572](#2572))
([287251a](287251a))
* **skill:** Attach user agent metadata for generated skill
([#2697](#2697))
([9598a6a](9598a6a))
* **skills:** Add additional-notes flag to generate skills command
([#2696](#2696))
([73bf962](73bf962))
* **skill:** Update skill generation logic
([#2646](#2646))
([c233eee](c233eee))
* **source/alloydb:** Restructure prebuilt toolsets
([#2639](#2639))
([5f3f063](5f3f063))
* **source/bigquery:** Restructure prebuilt toolsets
([#2637](#2637))
([dc984ba](dc984ba))
* **sources/bigquery:** Support custom oauth header name
([#2564](#2564))
([d3baf77](d3baf77))
* **source/cloudsql:** Restructure prebuilt toolsets
([#2635](#2635))
([99613dc](99613dc))
* **source/dataplex:** Restructure prebuilt toolsets
([#2640](#2640))
([acb9a80](acb9a80))
* **source/firestore:** Restructure prebuilt toolsets
([#2636](#2636))
([22ab7b9](22ab7b9))
* **source/oss-db:** Restructure prebuilt toolsets
([#2638](#2638))
([5196c6a](5196c6a))
* **source/spanner:** Restructure prebuilt toolsets
([#2641](#2641))
([ea2b698](ea2b698))
* Telemetry metrics updates as per semantic convention
([#2566](#2566))
([131d764](131d764))
* **tools/mongodb:** Add tool annotations to MongoDB tools for improved
LLM understanding
([#2219](#2219))
([b7a5f80](b7a5f80))
* **tools/serverless-spark:** Add get_session_template tool
([#2308](#2308))
([a136e16](a136e16))
* **tools/serverless-spark:** Add list/get sessions tools
([#2576](#2576))
([a554298](a554298))


### Bug Fixes

* Improve list locks integration test for postgres
([#2279](#2279))
([d9ebe5d](d9ebe5d))
* **mcp:** Guard nil SSE session lookup and return 400 for missing
session
([#2681](#2681))
([f66189f](f66189f))
* **oracle:** Update oracle-execute-sql tool interface to match source
signature
([#2627](#2627))
([81699a3](81699a3))
* Return AllParams for GetParameter() for tools with
templateParameter([#2734](#2734))
([bfd7ba6](bfd7ba6))
* **server/mcp:** Scope defer span.End inside loop iteration
([#2558](#2558))
([c88a62d](c88a62d)),
closes [#2549](#2549)
* **skill:** Fix env variable propagation
([#2645](#2645))
([5271368](5271368))
* **sources/looker:** Looker and looker-dev prebuilt tools should share
one source definition.
([#2620](#2620))
([df7f2fd](df7f2fd))
* **telemetry:** Histogram buckets from OTel standard to MCP standards
([#2729](#2729))
([87cd4a0](87cd4a0))
* **ui:** Remove module from script
([#2703](#2703))
([6943ab6](6943ab6))
* Update toolset attributes naming
([#2554](#2554))
([3d6ae4e](3d6ae4e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
github-actions Bot pushed a commit that referenced this pull request Mar 13, 2026
@Yuan325 @release-please
deploy: chore(main): release 0.29.0 (#2608)
76dd99a 
🤖 I have created a release *beep* *boop*
---

##
[0.29.0](v0.28.0...v0.29.0)
(2026-03-13)

### ⚠ BREAKING CHANGES

* **source/alloydb:** restructure prebuilt toolsets
([#2639](#2639))
* **source/spanner:** restructure prebuilt toolsets
([#2641](#2641))
* **source/dataplex:** restructure prebuilt toolsets
([#2640](#2640))
* **source/oss-db:** restructure prebuilt toolsets
([#2638](#2638))
* **source/cloudsql:** restructure prebuilt toolsets
([#2635](#2635))
* **source/bigquery:** restructure prebuilt toolsets
([#2637](#2637))
* **source/firestore:** restructure prebuilt toolsets
([#2636](#2636))
* telemetry metrics updates as per semantic convention
([#2566](#2566))

### Features

* Add user agent to embeddings generation
([#2572](#2572))
([287251a](287251a))
* **skill:** Attach user agent metadata for generated skill
([#2697](#2697))
([9598a6a](9598a6a))
* **skills:** Add additional-notes flag to generate skills command
([#2696](#2696))
([73bf962](73bf962))
* **skill:** Update skill generation logic
([#2646](#2646))
([c233eee](c233eee))
* **source/alloydb:** Restructure prebuilt toolsets
([#2639](#2639))
([5f3f063](5f3f063))
* **source/bigquery:** Restructure prebuilt toolsets
([#2637](#2637))
([dc984ba](dc984ba))
* **sources/bigquery:** Support custom oauth header name
([#2564](#2564))
([d3baf77](d3baf77))
* **source/cloudsql:** Restructure prebuilt toolsets
([#2635](#2635))
([99613dc](99613dc))
* **source/dataplex:** Restructure prebuilt toolsets
([#2640](#2640))
([acb9a80](acb9a80))
* **source/firestore:** Restructure prebuilt toolsets
([#2636](#2636))
([22ab7b9](22ab7b9))
* **source/oss-db:** Restructure prebuilt toolsets
([#2638](#2638))
([5196c6a](5196c6a))
* **source/spanner:** Restructure prebuilt toolsets
([#2641](#2641))
([ea2b698](ea2b698))
* Telemetry metrics updates as per semantic convention
([#2566](#2566))
([131d764](131d764))
* **tools/mongodb:** Add tool annotations to MongoDB tools for improved
LLM understanding
([#2219](#2219))
([b7a5f80](b7a5f80))
* **tools/serverless-spark:** Add get_session_template tool
([#2308](#2308))
([a136e16](a136e16))
* **tools/serverless-spark:** Add list/get sessions tools
([#2576](#2576))
([a554298](a554298))

### Bug Fixes

* Improve list locks integration test for postgres
([#2279](#2279))
([d9ebe5d](d9ebe5d))
* **mcp:** Guard nil SSE session lookup and return 400 for missing
session
([#2681](#2681))
([f66189f](f66189f))
* **oracle:** Update oracle-execute-sql tool interface to match source
signature
([#2627](#2627))
([81699a3](81699a3))
* Return AllParams for GetParameter() for tools with
templateParameter([#2734](#2734))
([bfd7ba6](bfd7ba6))
* **server/mcp:** Scope defer span.End inside loop iteration
([#2558](#2558))
([c88a62d](c88a62d)),
closes [#2549](#2549)
* **skill:** Fix env variable propagation
([#2645](#2645))
([5271368](5271368))
* **sources/looker:** Looker and looker-dev prebuilt tools should share
one source definition.
([#2620](#2620))
([df7f2fd](df7f2fd))
* **telemetry:** Histogram buckets from OTel standard to MCP standards
([#2729](#2729))
([87cd4a0](87cd4a0))
* **ui:** Remove module from script
([#2703](#2703))
([6943ab6](6943ab6))
* Update toolset attributes naming
([#2554](#2554))
([3d6ae4e](3d6ae4e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 39832a0
github-actions Bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Mar 13, 2026
@renovate-bot @release-please
deploy: chore(main): release 0.29.0 (googleapis#2608)
7bd96b9 
🤖 I have created a release *beep* *boop*
---

##
[0.29.0](googleapis/mcp-toolbox@v0.28.0...v0.29.0)
(2026-03-13)

### ⚠ BREAKING CHANGES

* **source/alloydb:** restructure prebuilt toolsets
([googleapis#2639](googleapis#2639))
* **source/spanner:** restructure prebuilt toolsets
([googleapis#2641](googleapis#2641))
* **source/dataplex:** restructure prebuilt toolsets
([googleapis#2640](googleapis#2640))
* **source/oss-db:** restructure prebuilt toolsets
([googleapis#2638](googleapis#2638))
* **source/cloudsql:** restructure prebuilt toolsets
([googleapis#2635](googleapis#2635))
* **source/bigquery:** restructure prebuilt toolsets
([googleapis#2637](googleapis#2637))
* **source/firestore:** restructure prebuilt toolsets
([googleapis#2636](googleapis#2636))
* telemetry metrics updates as per semantic convention
([googleapis#2566](googleapis#2566))

### Features

* Add user agent to embeddings generation
([googleapis#2572](googleapis#2572))
([287251a](googleapis@287251a))
* **skill:** Attach user agent metadata for generated skill
([googleapis#2697](googleapis#2697))
([9598a6a](googleapis@9598a6a))
* **skills:** Add additional-notes flag to generate skills command
([googleapis#2696](googleapis#2696))
([73bf962](googleapis@73bf962))
* **skill:** Update skill generation logic
([googleapis#2646](googleapis#2646))
([c233eee](googleapis@c233eee))
* **source/alloydb:** Restructure prebuilt toolsets
([googleapis#2639](googleapis#2639))
([5f3f063](googleapis@5f3f063))
* **source/bigquery:** Restructure prebuilt toolsets
([googleapis#2637](googleapis#2637))
([dc984ba](googleapis@dc984ba))
* **sources/bigquery:** Support custom oauth header name
([googleapis#2564](googleapis#2564))
([d3baf77](googleapis@d3baf77))
* **source/cloudsql:** Restructure prebuilt toolsets
([googleapis#2635](googleapis#2635))
([99613dc](googleapis@99613dc))
* **source/dataplex:** Restructure prebuilt toolsets
([googleapis#2640](googleapis#2640))
([acb9a80](googleapis@acb9a80))
* **source/firestore:** Restructure prebuilt toolsets
([googleapis#2636](googleapis#2636))
([22ab7b9](googleapis@22ab7b9))
* **source/oss-db:** Restructure prebuilt toolsets
([googleapis#2638](googleapis#2638))
([5196c6a](googleapis@5196c6a))
* **source/spanner:** Restructure prebuilt toolsets
([googleapis#2641](googleapis#2641))
([ea2b698](googleapis@ea2b698))
* Telemetry metrics updates as per semantic convention
([googleapis#2566](googleapis#2566))
([131d764](googleapis@131d764))
* **tools/mongodb:** Add tool annotations to MongoDB tools for improved
LLM understanding
([googleapis#2219](googleapis#2219))
([b7a5f80](googleapis@b7a5f80))
* **tools/serverless-spark:** Add get_session_template tool
([googleapis#2308](googleapis#2308))
([a136e16](googleapis@a136e16))
* **tools/serverless-spark:** Add list/get sessions tools
([googleapis#2576](googleapis#2576))
([a554298](googleapis@a554298))

### Bug Fixes

* Improve list locks integration test for postgres
([googleapis#2279](googleapis#2279))
([d9ebe5d](googleapis@d9ebe5d))
* **mcp:** Guard nil SSE session lookup and return 400 for missing
session
([googleapis#2681](googleapis#2681))
([f66189f](googleapis@f66189f))
* **oracle:** Update oracle-execute-sql tool interface to match source
signature
([googleapis#2627](googleapis#2627))
([81699a3](googleapis@81699a3))
* Return AllParams for GetParameter() for tools with
templateParameter([googleapis#2734](googleapis#2734))
([bfd7ba6](googleapis@bfd7ba6))
* **server/mcp:** Scope defer span.End inside loop iteration
([googleapis#2558](googleapis#2558))
([c88a62d](googleapis@c88a62d)),
closes [googleapis#2549](googleapis#2549)
* **skill:** Fix env variable propagation
([googleapis#2645](googleapis#2645))
([5271368](googleapis@5271368))
* **sources/looker:** Looker and looker-dev prebuilt tools should share
one source definition.
([googleapis#2620](googleapis#2620))
([df7f2fd](googleapis@df7f2fd))
* **telemetry:** Histogram buckets from OTel standard to MCP standards
([googleapis#2729](googleapis#2729))
([87cd4a0](googleapis@87cd4a0))
* **ui:** Remove module from script
([googleapis#2703](googleapis#2703))
([6943ab6](googleapis@6943ab6))
* Update toolset attributes naming
([googleapis#2554](googleapis#2554))
([3d6ae4e](googleapis@3d6ae4e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 39832a0
github-actions Bot pushed a commit to Jaleel-zhu/genai-toolbox that referenced this pull request Mar 13, 2026
@pull @release-please
deploy: chore(main): release 0.29.0 (googleapis#2608)
e658ef2 
🤖 I have created a release *beep* *boop*
---

##
[0.29.0](googleapis/mcp-toolbox@v0.28.0...v0.29.0)
(2026-03-13)

### ⚠ BREAKING CHANGES

* **source/alloydb:** restructure prebuilt toolsets
([googleapis#2639](googleapis#2639))
* **source/spanner:** restructure prebuilt toolsets
([googleapis#2641](googleapis#2641))
* **source/dataplex:** restructure prebuilt toolsets
([googleapis#2640](googleapis#2640))
* **source/oss-db:** restructure prebuilt toolsets
([googleapis#2638](googleapis#2638))
* **source/cloudsql:** restructure prebuilt toolsets
([googleapis#2635](googleapis#2635))
* **source/bigquery:** restructure prebuilt toolsets
([googleapis#2637](googleapis#2637))
* **source/firestore:** restructure prebuilt toolsets
([googleapis#2636](googleapis#2636))
* telemetry metrics updates as per semantic convention
([googleapis#2566](googleapis#2566))

### Features

* Add user agent to embeddings generation
([googleapis#2572](googleapis#2572))
([287251a](googleapis@287251a))
* **skill:** Attach user agent metadata for generated skill
([googleapis#2697](googleapis#2697))
([9598a6a](googleapis@9598a6a))
* **skills:** Add additional-notes flag to generate skills command
([googleapis#2696](googleapis#2696))
([73bf962](googleapis@73bf962))
* **skill:** Update skill generation logic
([googleapis#2646](googleapis#2646))
([c233eee](googleapis@c233eee))
* **source/alloydb:** Restructure prebuilt toolsets
([googleapis#2639](googleapis#2639))
([5f3f063](googleapis@5f3f063))
* **source/bigquery:** Restructure prebuilt toolsets
([googleapis#2637](googleapis#2637))
([dc984ba](googleapis@dc984ba))
* **sources/bigquery:** Support custom oauth header name
([googleapis#2564](googleapis#2564))
([d3baf77](googleapis@d3baf77))
* **source/cloudsql:** Restructure prebuilt toolsets
([googleapis#2635](googleapis#2635))
([99613dc](googleapis@99613dc))
* **source/dataplex:** Restructure prebuilt toolsets
([googleapis#2640](googleapis#2640))
([acb9a80](googleapis@acb9a80))
* **source/firestore:** Restructure prebuilt toolsets
([googleapis#2636](googleapis#2636))
([22ab7b9](googleapis@22ab7b9))
* **source/oss-db:** Restructure prebuilt toolsets
([googleapis#2638](googleapis#2638))
([5196c6a](googleapis@5196c6a))
* **source/spanner:** Restructure prebuilt toolsets
([googleapis#2641](googleapis#2641))
([ea2b698](googleapis@ea2b698))
* Telemetry metrics updates as per semantic convention
([googleapis#2566](googleapis#2566))
([131d764](googleapis@131d764))
* **tools/mongodb:** Add tool annotations to MongoDB tools for improved
LLM understanding
([googleapis#2219](googleapis#2219))
([b7a5f80](googleapis@b7a5f80))
* **tools/serverless-spark:** Add get_session_template tool
([googleapis#2308](googleapis#2308))
([a136e16](googleapis@a136e16))
* **tools/serverless-spark:** Add list/get sessions tools
([googleapis#2576](googleapis#2576))
([a554298](googleapis@a554298))

### Bug Fixes

* Improve list locks integration test for postgres
([googleapis#2279](googleapis#2279))
([d9ebe5d](googleapis@d9ebe5d))
* **mcp:** Guard nil SSE session lookup and return 400 for missing
session
([googleapis#2681](googleapis#2681))
([f66189f](googleapis@f66189f))
* **oracle:** Update oracle-execute-sql tool interface to match source
signature
([googleapis#2627](googleapis#2627))
([81699a3](googleapis@81699a3))
* Return AllParams for GetParameter() for tools with
templateParameter([googleapis#2734](googleapis#2734))
([bfd7ba6](googleapis@bfd7ba6))
* **server/mcp:** Scope defer span.End inside loop iteration
([googleapis#2558](googleapis#2558))
([c88a62d](googleapis@c88a62d)),
closes [googleapis#2549](googleapis#2549)
* **skill:** Fix env variable propagation
([googleapis#2645](googleapis#2645))
([5271368](googleapis@5271368))
* **sources/looker:** Looker and looker-dev prebuilt tools should share
one source definition.
([googleapis#2620](googleapis#2620))
([df7f2fd](googleapis@df7f2fd))
* **telemetry:** Histogram buckets from OTel standard to MCP standards
([googleapis#2729](googleapis#2729))
([87cd4a0](googleapis@87cd4a0))
* **ui:** Remove module from script
([googleapis#2703](googleapis#2703))
([6943ab6](googleapis@6943ab6))
* Update toolset attributes naming
([googleapis#2554](googleapis#2554))
([3d6ae4e](googleapis@3d6ae4e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 39832a0
@BrewTestBot BrewTestBot mentioned this pull request Mar 13, 2026
Merged
NightStack15 added a commit to NightStack15/googleapis-_-genai-toolbox that referenced this pull request Mar 20, 2026
@NightStack15 @release-please @Yuan325
chore(main): release 0.29.0 (#2608)
8c0d6a0 
🤖 I have created a release *beep* *boop*
---


##
[0.29.0](googleapis/mcp-toolbox@v0.28.0...v0.29.0)
(2026-03-13)


### ⚠ BREAKING CHANGES

* **source/alloydb:** restructure prebuilt toolsets
([#2639](googleapis/mcp-toolbox#2639))
* **source/spanner:** restructure prebuilt toolsets
([#2641](googleapis/mcp-toolbox#2641))
* **source/dataplex:** restructure prebuilt toolsets
([#2640](googleapis/mcp-toolbox#2640))
* **source/oss-db:** restructure prebuilt toolsets
([#2638](googleapis/mcp-toolbox#2638))
* **source/cloudsql:** restructure prebuilt toolsets
([#2635](googleapis/mcp-toolbox#2635))
* **source/bigquery:** restructure prebuilt toolsets
([#2637](googleapis/mcp-toolbox#2637))
* **source/firestore:** restructure prebuilt toolsets
([#2636](googleapis/mcp-toolbox#2636))
* telemetry metrics updates as per semantic convention
([#2566](googleapis/mcp-toolbox#2566))

### Features

* Add user agent to embeddings generation
([#2572](googleapis/mcp-toolbox#2572))
([287251a](googleapis/mcp-toolbox@287251a))
* **skill:** Attach user agent metadata for generated skill
([#2697](googleapis/mcp-toolbox#2697))
([9598a6a](googleapis/mcp-toolbox@9598a6a))
* **skills:** Add additional-notes flag to generate skills command
([#2696](googleapis/mcp-toolbox#2696))
([73bf962](googleapis/mcp-toolbox@73bf962))
* **skill:** Update skill generation logic
([#2646](googleapis/mcp-toolbox#2646))
([c233eee](googleapis/mcp-toolbox@c233eee))
* **source/alloydb:** Restructure prebuilt toolsets
([#2639](googleapis/mcp-toolbox#2639))
([5f3f063](googleapis/mcp-toolbox@5f3f063))
* **source/bigquery:** Restructure prebuilt toolsets
([#2637](googleapis/mcp-toolbox#2637))
([dc984ba](googleapis/mcp-toolbox@dc984ba))
* **sources/bigquery:** Support custom oauth header name
([#2564](googleapis/mcp-toolbox#2564))
([d3baf77](googleapis/mcp-toolbox@d3baf77))
* **source/cloudsql:** Restructure prebuilt toolsets
([#2635](googleapis/mcp-toolbox#2635))
([99613dc](googleapis/mcp-toolbox@99613dc))
* **source/dataplex:** Restructure prebuilt toolsets
([#2640](googleapis/mcp-toolbox#2640))
([acb9a80](googleapis/mcp-toolbox@acb9a80))
* **source/firestore:** Restructure prebuilt toolsets
([#2636](googleapis/mcp-toolbox#2636))
([22ab7b9](googleapis/mcp-toolbox@22ab7b9))
* **source/oss-db:** Restructure prebuilt toolsets
([#2638](googleapis/mcp-toolbox#2638))
([5196c6a](googleapis/mcp-toolbox@5196c6a))
* **source/spanner:** Restructure prebuilt toolsets
([#2641](googleapis/mcp-toolbox#2641))
([ea2b698](googleapis/mcp-toolbox@ea2b698))
* Telemetry metrics updates as per semantic convention
([#2566](googleapis/mcp-toolbox#2566))
([131d764](googleapis/mcp-toolbox@131d764))
* **tools/mongodb:** Add tool annotations to MongoDB tools for improved
LLM understanding
([#2219](googleapis/mcp-toolbox#2219))
([b7a5f80](googleapis/mcp-toolbox@b7a5f80))
* **tools/serverless-spark:** Add get_session_template tool
([#2308](googleapis/mcp-toolbox#2308))
([a136e16](googleapis/mcp-toolbox@a136e16))
* **tools/serverless-spark:** Add list/get sessions tools
([#2576](googleapis/mcp-toolbox#2576))
([a554298](googleapis/mcp-toolbox@a554298))


### Bug Fixes

* Improve list locks integration test for postgres
([#2279](googleapis/mcp-toolbox#2279))
([d9ebe5d](googleapis/mcp-toolbox@d9ebe5d))
* **mcp:** Guard nil SSE session lookup and return 400 for missing
session
([#2681](googleapis/mcp-toolbox#2681))
([f66189f](googleapis/mcp-toolbox@f66189f))
* **oracle:** Update oracle-execute-sql tool interface to match source
signature
([#2627](googleapis/mcp-toolbox#2627))
([81699a3](googleapis/mcp-toolbox@81699a3))
* Return AllParams for GetParameter() for tools with
templateParameter([#2734](googleapis/mcp-toolbox#2734))
([bfd7ba6](googleapis/mcp-toolbox@bfd7ba6))
* **server/mcp:** Scope defer span.End inside loop iteration
([#2558](googleapis/mcp-toolbox#2558))
([c88a62d](googleapis/mcp-toolbox@c88a62d)),
closes [#2549](googleapis/mcp-toolbox#2549)
* **skill:** Fix env variable propagation
([#2645](googleapis/mcp-toolbox#2645))
([5271368](googleapis/mcp-toolbox@5271368))
* **sources/looker:** Looker and looker-dev prebuilt tools should share
one source definition.
([#2620](googleapis/mcp-toolbox#2620))
([df7f2fd](googleapis/mcp-toolbox@df7f2fd))
* **telemetry:** Histogram buckets from OTel standard to MCP standards
([#2729](googleapis/mcp-toolbox#2729))
([87cd4a0](googleapis/mcp-toolbox@87cd4a0))
* **ui:** Remove module from script
([#2703](googleapis/mcp-toolbox#2703))
([6943ab6](googleapis/mcp-toolbox@6943ab6))
* Update toolset attributes naming
([#2554](googleapis/mcp-toolbox#2554))
([3d6ae4e](googleapis/mcp-toolbox@3d6ae4e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
NirajNandre pushed a commit to NirajNandre/genai-toolbox-fork that referenced this pull request Mar 24, 2026
@helloeve @NirajNandre
fix(skill): fix env variable propagation (googleapis#2645)
f9959b0 
This PR refactors the tool file parsing logic by introducing a new
ToolsFileParser struct. This encapsulation allows for stateful parsing,
specifically enabling the tracking of resolved environment variables
during configuration loading. This is useful for skill generation, where
we can now identify and omit default values that correspond to
environment variables, ensuring more precise generated skill.
NirajNandre pushed a commit to NirajNandre/genai-toolbox-fork that referenced this pull request Mar 24, 2026
@release-please @Yuan325 @NirajNandre
chore(main): release 0.29.0 (googleapis#2608)
ae10114 
🤖 I have created a release *beep* *boop*
---


##
[0.29.0](googleapis/mcp-toolbox@v0.28.0...v0.29.0)
(2026-03-13)


### ⚠ BREAKING CHANGES

* **source/alloydb:** restructure prebuilt toolsets
([googleapis#2639](googleapis#2639))
* **source/spanner:** restructure prebuilt toolsets
([googleapis#2641](googleapis#2641))
* **source/dataplex:** restructure prebuilt toolsets
([googleapis#2640](googleapis#2640))
* **source/oss-db:** restructure prebuilt toolsets
([googleapis#2638](googleapis#2638))
* **source/cloudsql:** restructure prebuilt toolsets
([googleapis#2635](googleapis#2635))
* **source/bigquery:** restructure prebuilt toolsets
([googleapis#2637](googleapis#2637))
* **source/firestore:** restructure prebuilt toolsets
([googleapis#2636](googleapis#2636))
* telemetry metrics updates as per semantic convention
([googleapis#2566](googleapis#2566))

### Features

* Add user agent to embeddings generation
([googleapis#2572](googleapis#2572))
([287251a](googleapis@287251a))
* **skill:** Attach user agent metadata for generated skill
([googleapis#2697](googleapis#2697))
([9598a6a](googleapis@9598a6a))
* **skills:** Add additional-notes flag to generate skills command
([googleapis#2696](googleapis#2696))
([73bf962](googleapis@73bf962))
* **skill:** Update skill generation logic
([googleapis#2646](googleapis#2646))
([c233eee](googleapis@c233eee))
* **source/alloydb:** Restructure prebuilt toolsets
([googleapis#2639](googleapis#2639))
([5f3f063](googleapis@5f3f063))
* **source/bigquery:** Restructure prebuilt toolsets
([googleapis#2637](googleapis#2637))
([dc984ba](googleapis@dc984ba))
* **sources/bigquery:** Support custom oauth header name
([googleapis#2564](googleapis#2564))
([d3baf77](googleapis@d3baf77))
* **source/cloudsql:** Restructure prebuilt toolsets
([googleapis#2635](googleapis#2635))
([99613dc](googleapis@99613dc))
* **source/dataplex:** Restructure prebuilt toolsets
([googleapis#2640](googleapis#2640))
([acb9a80](googleapis@acb9a80))
* **source/firestore:** Restructure prebuilt toolsets
([googleapis#2636](googleapis#2636))
([22ab7b9](googleapis@22ab7b9))
* **source/oss-db:** Restructure prebuilt toolsets
([googleapis#2638](googleapis#2638))
([5196c6a](googleapis@5196c6a))
* **source/spanner:** Restructure prebuilt toolsets
([googleapis#2641](googleapis#2641))
([ea2b698](googleapis@ea2b698))
* Telemetry metrics updates as per semantic convention
([googleapis#2566](googleapis#2566))
([131d764](googleapis@131d764))
* **tools/mongodb:** Add tool annotations to MongoDB tools for improved
LLM understanding
([googleapis#2219](googleapis#2219))
([b7a5f80](googleapis@b7a5f80))
* **tools/serverless-spark:** Add get_session_template tool
([googleapis#2308](googleapis#2308))
([a136e16](googleapis@a136e16))
* **tools/serverless-spark:** Add list/get sessions tools
([googleapis#2576](googleapis#2576))
([a554298](googleapis@a554298))


### Bug Fixes

* Improve list locks integration test for postgres
([googleapis#2279](googleapis#2279))
([d9ebe5d](googleapis@d9ebe5d))
* **mcp:** Guard nil SSE session lookup and return 400 for missing
session
([googleapis#2681](googleapis#2681))
([f66189f](googleapis@f66189f))
* **oracle:** Update oracle-execute-sql tool interface to match source
signature
([googleapis#2627](googleapis#2627))
([81699a3](googleapis@81699a3))
* Return AllParams for GetParameter() for tools with
templateParameter([googleapis#2734](googleapis#2734))
([bfd7ba6](googleapis@bfd7ba6))
* **server/mcp:** Scope defer span.End inside loop iteration
([googleapis#2558](googleapis#2558))
([c88a62d](googleapis@c88a62d)),
closes [googleapis#2549](googleapis#2549)
* **skill:** Fix env variable propagation
([googleapis#2645](googleapis#2645))
([5271368](googleapis@5271368))
* **sources/looker:** Looker and looker-dev prebuilt tools should share
one source definition.
([googleapis#2620](googleapis#2620))
([df7f2fd](googleapis@df7f2fd))
* **telemetry:** Histogram buckets from OTel standard to MCP standards
([googleapis#2729](googleapis#2729))
([87cd4a0](googleapis@87cd4a0))
* **ui:** Remove module from script
([googleapis#2703](googleapis#2703))
([6943ab6](googleapis@6943ab6))
* Update toolset attributes naming
([googleapis#2554](googleapis#2554))
([3d6ae4e](googleapis@3d6ae4e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

@twishabansal twishabansal twishabansal approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@averikitsch averikitsch

@twishabansal twishabansal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@helloeve @averikitsch @twishabansal @Yuan325