ci(postgres): improve list locks integration test for postgres by ravisiddhu · Pull Request #2279 · googleapis/mcp-toolbox

ravisiddhu · 2026-01-08T13:37:42Z

Description

Fix: Fixed the flakiness in the list locks integration test for postgres

go test -tags=integration tests/postgres/postgres_integration_test.go
ok      command-line-arguments  14.392s

PR Checklist

Make sure you reviewed
CONTRIBUTING.md
Make sure to open an issue as a
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Make sure to add ! if this involve a breaking change

🛠️ Fixes #1738

gemini-code-assist · 2026-01-08T13:37:58Z

Summary of Changes

Hello @ravisiddhu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves flakiness in the PostgreSQL list locks integration test by implementing a robust setup mechanism. It ensures that a table is consistently created and locked before the test runs, providing a stable environment for verifying lock detection. The changes also streamline the test's data handling and assertion logic to accurately reflect the expected lock state.

Highlights

Improved Test Reliability: Introduced a new helper function, CreateAndLockPostgresTable, to programmatically create a test table and acquire an ACCESS EXCLUSIVE lock on it. This ensures a consistent and predictable state for the list locks integration test, addressing previous flakiness.
Refactored Test Logic: The RunPostgresListLocksTest function now utilizes the new helper to set up the locked table, and the expectResults flag for the test case has been updated to true, as a lock is now guaranteed to exist.
Updated Lock Details Structure and Verification: The lockDetails struct used for unmarshalling test results has been simplified, and the assertion logic has been modified to specifically check for the presence of AccessExclusiveLock within the Locks field, aligning with the new way lock information is retrieved.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request effectively addresses the flakiness of the list_locks integration test for PostgreSQL. The introduction of the CreateAndLockPostgresTable helper function is a solid approach to establish a deterministic state by creating a table and applying an explicit lock. The subsequent updates to the test case, including adjusting the expected results and refining the validation logic to check for a specific AccessExclusiveLock, are logical and improve the test's reliability. I have one suggestion to enhance the new helper function by using best practices for constructing SQL queries to mitigate any potential for SQL injection, even within a test context.

duwenxin99 · 2026-02-19T16:51:23Z

Hi @ravisiddhu, could you fix the lint errors? Thanks!

averikitsch · 2026-03-04T19:57:30Z

/gcbrun

Yuan325 · 2026-03-12T18:51:32Z

/gcbrun

## Description Fix: Fixed the flakiness in the list locks integration test for postgres ``` go test -tags=integration tests/postgres/postgres_integration_test.go ok command-line-arguments 14.392s ``` ## PR Checklist - [X] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [X] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [X] Ensure the tests and linter pass - [X] Code coverage does not decrease (if any source code was changed) - [X] Appropriate docs were updated (if necessary) - [X] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1738

🤖 I have created a release *beep* *boop* --- ## [0.29.0](v0.28.0...v0.29.0) (2026-03-13) ### ⚠ BREAKING CHANGES * **source/alloydb:** restructure prebuilt toolsets ([#2639](#2639)) * **source/spanner:** restructure prebuilt toolsets ([#2641](#2641)) * **source/dataplex:** restructure prebuilt toolsets ([#2640](#2640)) * **source/oss-db:** restructure prebuilt toolsets ([#2638](#2638)) * **source/cloudsql:** restructure prebuilt toolsets ([#2635](#2635)) * **source/bigquery:** restructure prebuilt toolsets ([#2637](#2637)) * **source/firestore:** restructure prebuilt toolsets ([#2636](#2636)) * telemetry metrics updates as per semantic convention ([#2566](#2566)) ### Features * Add user agent to embeddings generation ([#2572](#2572)) ([287251a](287251a)) * **skill:** Attach user agent metadata for generated skill ([#2697](#2697)) ([9598a6a](9598a6a)) * **skills:** Add additional-notes flag to generate skills command ([#2696](#2696)) ([73bf962](73bf962)) * **skill:** Update skill generation logic ([#2646](#2646)) ([c233eee](c233eee)) * **source/alloydb:** Restructure prebuilt toolsets ([#2639](#2639)) ([5f3f063](5f3f063)) * **source/bigquery:** Restructure prebuilt toolsets ([#2637](#2637)) ([dc984ba](dc984ba)) * **sources/bigquery:** Support custom oauth header name ([#2564](#2564)) ([d3baf77](d3baf77)) * **source/cloudsql:** Restructure prebuilt toolsets ([#2635](#2635)) ([99613dc](99613dc)) * **source/dataplex:** Restructure prebuilt toolsets ([#2640](#2640)) ([acb9a80](acb9a80)) * **source/firestore:** Restructure prebuilt toolsets ([#2636](#2636)) ([22ab7b9](22ab7b9)) * **source/oss-db:** Restructure prebuilt toolsets ([#2638](#2638)) ([5196c6a](5196c6a)) * **source/spanner:** Restructure prebuilt toolsets ([#2641](#2641)) ([ea2b698](ea2b698)) * Telemetry metrics updates as per semantic convention ([#2566](#2566)) ([131d764](131d764)) * **tools/mongodb:** Add tool annotations to MongoDB tools for improved LLM understanding ([#2219](#2219)) ([b7a5f80](b7a5f80)) * **tools/serverless-spark:** Add get_session_template tool ([#2308](#2308)) ([a136e16](a136e16)) * **tools/serverless-spark:** Add list/get sessions tools ([#2576](#2576)) ([a554298](a554298)) ### Bug Fixes * Improve list locks integration test for postgres ([#2279](#2279)) ([d9ebe5d](d9ebe5d)) * **mcp:** Guard nil SSE session lookup and return 400 for missing session ([#2681](#2681)) ([f66189f](f66189f)) * **oracle:** Update oracle-execute-sql tool interface to match source signature ([#2627](#2627)) ([81699a3](81699a3)) * Return AllParams for GetParameter() for tools with templateParameter([#2734](#2734)) ([bfd7ba6](bfd7ba6)) * **server/mcp:** Scope defer span.End inside loop iteration ([#2558](#2558)) ([c88a62d](c88a62d)), closes [#2549](#2549) * **skill:** Fix env variable propagation ([#2645](#2645)) ([5271368](5271368)) * **sources/looker:** Looker and looker-dev prebuilt tools should share one source definition. ([#2620](#2620)) ([df7f2fd](df7f2fd)) * **telemetry:** Histogram buckets from OTel standard to MCP standards ([#2729](#2729)) ([87cd4a0](87cd4a0)) * **ui:** Remove module from script ([#2703](#2703)) ([6943ab6](6943ab6)) * Update toolset attributes naming ([#2554](#2554)) ([3d6ae4e](3d6ae4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.29.0](v0.28.0...v0.29.0) (2026-03-13) ### ⚠ BREAKING CHANGES * **source/alloydb:** restructure prebuilt toolsets ([#2639](#2639)) * **source/spanner:** restructure prebuilt toolsets ([#2641](#2641)) * **source/dataplex:** restructure prebuilt toolsets ([#2640](#2640)) * **source/oss-db:** restructure prebuilt toolsets ([#2638](#2638)) * **source/cloudsql:** restructure prebuilt toolsets ([#2635](#2635)) * **source/bigquery:** restructure prebuilt toolsets ([#2637](#2637)) * **source/firestore:** restructure prebuilt toolsets ([#2636](#2636)) * telemetry metrics updates as per semantic convention ([#2566](#2566)) ### Features * Add user agent to embeddings generation ([#2572](#2572)) ([287251a](287251a)) * **skill:** Attach user agent metadata for generated skill ([#2697](#2697)) ([9598a6a](9598a6a)) * **skills:** Add additional-notes flag to generate skills command ([#2696](#2696)) ([73bf962](73bf962)) * **skill:** Update skill generation logic ([#2646](#2646)) ([c233eee](c233eee)) * **source/alloydb:** Restructure prebuilt toolsets ([#2639](#2639)) ([5f3f063](5f3f063)) * **source/bigquery:** Restructure prebuilt toolsets ([#2637](#2637)) ([dc984ba](dc984ba)) * **sources/bigquery:** Support custom oauth header name ([#2564](#2564)) ([d3baf77](d3baf77)) * **source/cloudsql:** Restructure prebuilt toolsets ([#2635](#2635)) ([99613dc](99613dc)) * **source/dataplex:** Restructure prebuilt toolsets ([#2640](#2640)) ([acb9a80](acb9a80)) * **source/firestore:** Restructure prebuilt toolsets ([#2636](#2636)) ([22ab7b9](22ab7b9)) * **source/oss-db:** Restructure prebuilt toolsets ([#2638](#2638)) ([5196c6a](5196c6a)) * **source/spanner:** Restructure prebuilt toolsets ([#2641](#2641)) ([ea2b698](ea2b698)) * Telemetry metrics updates as per semantic convention ([#2566](#2566)) ([131d764](131d764)) * **tools/mongodb:** Add tool annotations to MongoDB tools for improved LLM understanding ([#2219](#2219)) ([b7a5f80](b7a5f80)) * **tools/serverless-spark:** Add get_session_template tool ([#2308](#2308)) ([a136e16](a136e16)) * **tools/serverless-spark:** Add list/get sessions tools ([#2576](#2576)) ([a554298](a554298)) ### Bug Fixes * Improve list locks integration test for postgres ([#2279](#2279)) ([d9ebe5d](d9ebe5d)) * **mcp:** Guard nil SSE session lookup and return 400 for missing session ([#2681](#2681)) ([f66189f](f66189f)) * **oracle:** Update oracle-execute-sql tool interface to match source signature ([#2627](#2627)) ([81699a3](81699a3)) * Return AllParams for GetParameter() for tools with templateParameter([#2734](#2734)) ([bfd7ba6](bfd7ba6)) * **server/mcp:** Scope defer span.End inside loop iteration ([#2558](#2558)) ([c88a62d](c88a62d)), closes [#2549](#2549) * **skill:** Fix env variable propagation ([#2645](#2645)) ([5271368](5271368)) * **sources/looker:** Looker and looker-dev prebuilt tools should share one source definition. ([#2620](#2620)) ([df7f2fd](df7f2fd)) * **telemetry:** Histogram buckets from OTel standard to MCP standards ([#2729](#2729)) ([87cd4a0](87cd4a0)) * **ui:** Remove module from script ([#2703](#2703)) ([6943ab6](6943ab6)) * Update toolset attributes naming ([#2554](#2554)) ([3d6ae4e](3d6ae4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 39832a0

🤖 I have created a release *beep* *boop* --- ## [0.29.0](googleapis/mcp-toolbox@v0.28.0...v0.29.0) (2026-03-13) ### ⚠ BREAKING CHANGES * **source/alloydb:** restructure prebuilt toolsets ([googleapis#2639](googleapis#2639)) * **source/spanner:** restructure prebuilt toolsets ([googleapis#2641](googleapis#2641)) * **source/dataplex:** restructure prebuilt toolsets ([googleapis#2640](googleapis#2640)) * **source/oss-db:** restructure prebuilt toolsets ([googleapis#2638](googleapis#2638)) * **source/cloudsql:** restructure prebuilt toolsets ([googleapis#2635](googleapis#2635)) * **source/bigquery:** restructure prebuilt toolsets ([googleapis#2637](googleapis#2637)) * **source/firestore:** restructure prebuilt toolsets ([googleapis#2636](googleapis#2636)) * telemetry metrics updates as per semantic convention ([googleapis#2566](googleapis#2566)) ### Features * Add user agent to embeddings generation ([googleapis#2572](googleapis#2572)) ([287251a](googleapis@287251a)) * **skill:** Attach user agent metadata for generated skill ([googleapis#2697](googleapis#2697)) ([9598a6a](googleapis@9598a6a)) * **skills:** Add additional-notes flag to generate skills command ([googleapis#2696](googleapis#2696)) ([73bf962](googleapis@73bf962)) * **skill:** Update skill generation logic ([googleapis#2646](googleapis#2646)) ([c233eee](googleapis@c233eee)) * **source/alloydb:** Restructure prebuilt toolsets ([googleapis#2639](googleapis#2639)) ([5f3f063](googleapis@5f3f063)) * **source/bigquery:** Restructure prebuilt toolsets ([googleapis#2637](googleapis#2637)) ([dc984ba](googleapis@dc984ba)) * **sources/bigquery:** Support custom oauth header name ([googleapis#2564](googleapis#2564)) ([d3baf77](googleapis@d3baf77)) * **source/cloudsql:** Restructure prebuilt toolsets ([googleapis#2635](googleapis#2635)) ([99613dc](googleapis@99613dc)) * **source/dataplex:** Restructure prebuilt toolsets ([googleapis#2640](googleapis#2640)) ([acb9a80](googleapis@acb9a80)) * **source/firestore:** Restructure prebuilt toolsets ([googleapis#2636](googleapis#2636)) ([22ab7b9](googleapis@22ab7b9)) * **source/oss-db:** Restructure prebuilt toolsets ([googleapis#2638](googleapis#2638)) ([5196c6a](googleapis@5196c6a)) * **source/spanner:** Restructure prebuilt toolsets ([googleapis#2641](googleapis#2641)) ([ea2b698](googleapis@ea2b698)) * Telemetry metrics updates as per semantic convention ([googleapis#2566](googleapis#2566)) ([131d764](googleapis@131d764)) * **tools/mongodb:** Add tool annotations to MongoDB tools for improved LLM understanding ([googleapis#2219](googleapis#2219)) ([b7a5f80](googleapis@b7a5f80)) * **tools/serverless-spark:** Add get_session_template tool ([googleapis#2308](googleapis#2308)) ([a136e16](googleapis@a136e16)) * **tools/serverless-spark:** Add list/get sessions tools ([googleapis#2576](googleapis#2576)) ([a554298](googleapis@a554298)) ### Bug Fixes * Improve list locks integration test for postgres ([googleapis#2279](googleapis#2279)) ([d9ebe5d](googleapis@d9ebe5d)) * **mcp:** Guard nil SSE session lookup and return 400 for missing session ([googleapis#2681](googleapis#2681)) ([f66189f](googleapis@f66189f)) * **oracle:** Update oracle-execute-sql tool interface to match source signature ([googleapis#2627](googleapis#2627)) ([81699a3](googleapis@81699a3)) * Return AllParams for GetParameter() for tools with templateParameter([googleapis#2734](googleapis#2734)) ([bfd7ba6](googleapis@bfd7ba6)) * **server/mcp:** Scope defer span.End inside loop iteration ([googleapis#2558](googleapis#2558)) ([c88a62d](googleapis@c88a62d)), closes [googleapis#2549](googleapis#2549) * **skill:** Fix env variable propagation ([googleapis#2645](googleapis#2645)) ([5271368](googleapis@5271368)) * **sources/looker:** Looker and looker-dev prebuilt tools should share one source definition. ([googleapis#2620](googleapis#2620)) ([df7f2fd](googleapis@df7f2fd)) * **telemetry:** Histogram buckets from OTel standard to MCP standards ([googleapis#2729](googleapis#2729)) ([87cd4a0](googleapis@87cd4a0)) * **ui:** Remove module from script ([googleapis#2703](googleapis#2703)) ([6943ab6](googleapis@6943ab6)) * Update toolset attributes naming ([googleapis#2554](googleapis#2554)) ([3d6ae4e](googleapis@3d6ae4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 39832a0

🤖 I have created a release *beep* *boop* --- ## [0.29.0](googleapis/mcp-toolbox@v0.28.0...v0.29.0) (2026-03-13) ### ⚠ BREAKING CHANGES * **source/alloydb:** restructure prebuilt toolsets ([#2639](googleapis/mcp-toolbox#2639)) * **source/spanner:** restructure prebuilt toolsets ([#2641](googleapis/mcp-toolbox#2641)) * **source/dataplex:** restructure prebuilt toolsets ([#2640](googleapis/mcp-toolbox#2640)) * **source/oss-db:** restructure prebuilt toolsets ([#2638](googleapis/mcp-toolbox#2638)) * **source/cloudsql:** restructure prebuilt toolsets ([#2635](googleapis/mcp-toolbox#2635)) * **source/bigquery:** restructure prebuilt toolsets ([#2637](googleapis/mcp-toolbox#2637)) * **source/firestore:** restructure prebuilt toolsets ([#2636](googleapis/mcp-toolbox#2636)) * telemetry metrics updates as per semantic convention ([#2566](googleapis/mcp-toolbox#2566)) ### Features * Add user agent to embeddings generation ([#2572](googleapis/mcp-toolbox#2572)) ([287251a](googleapis/mcp-toolbox@287251a)) * **skill:** Attach user agent metadata for generated skill ([#2697](googleapis/mcp-toolbox#2697)) ([9598a6a](googleapis/mcp-toolbox@9598a6a)) * **skills:** Add additional-notes flag to generate skills command ([#2696](googleapis/mcp-toolbox#2696)) ([73bf962](googleapis/mcp-toolbox@73bf962)) * **skill:** Update skill generation logic ([#2646](googleapis/mcp-toolbox#2646)) ([c233eee](googleapis/mcp-toolbox@c233eee)) * **source/alloydb:** Restructure prebuilt toolsets ([#2639](googleapis/mcp-toolbox#2639)) ([5f3f063](googleapis/mcp-toolbox@5f3f063)) * **source/bigquery:** Restructure prebuilt toolsets ([#2637](googleapis/mcp-toolbox#2637)) ([dc984ba](googleapis/mcp-toolbox@dc984ba)) * **sources/bigquery:** Support custom oauth header name ([#2564](googleapis/mcp-toolbox#2564)) ([d3baf77](googleapis/mcp-toolbox@d3baf77)) * **source/cloudsql:** Restructure prebuilt toolsets ([#2635](googleapis/mcp-toolbox#2635)) ([99613dc](googleapis/mcp-toolbox@99613dc)) * **source/dataplex:** Restructure prebuilt toolsets ([#2640](googleapis/mcp-toolbox#2640)) ([acb9a80](googleapis/mcp-toolbox@acb9a80)) * **source/firestore:** Restructure prebuilt toolsets ([#2636](googleapis/mcp-toolbox#2636)) ([22ab7b9](googleapis/mcp-toolbox@22ab7b9)) * **source/oss-db:** Restructure prebuilt toolsets ([#2638](googleapis/mcp-toolbox#2638)) ([5196c6a](googleapis/mcp-toolbox@5196c6a)) * **source/spanner:** Restructure prebuilt toolsets ([#2641](googleapis/mcp-toolbox#2641)) ([ea2b698](googleapis/mcp-toolbox@ea2b698)) * Telemetry metrics updates as per semantic convention ([#2566](googleapis/mcp-toolbox#2566)) ([131d764](googleapis/mcp-toolbox@131d764)) * **tools/mongodb:** Add tool annotations to MongoDB tools for improved LLM understanding ([#2219](googleapis/mcp-toolbox#2219)) ([b7a5f80](googleapis/mcp-toolbox@b7a5f80)) * **tools/serverless-spark:** Add get_session_template tool ([#2308](googleapis/mcp-toolbox#2308)) ([a136e16](googleapis/mcp-toolbox@a136e16)) * **tools/serverless-spark:** Add list/get sessions tools ([#2576](googleapis/mcp-toolbox#2576)) ([a554298](googleapis/mcp-toolbox@a554298)) ### Bug Fixes * Improve list locks integration test for postgres ([#2279](googleapis/mcp-toolbox#2279)) ([d9ebe5d](googleapis/mcp-toolbox@d9ebe5d)) * **mcp:** Guard nil SSE session lookup and return 400 for missing session ([#2681](googleapis/mcp-toolbox#2681)) ([f66189f](googleapis/mcp-toolbox@f66189f)) * **oracle:** Update oracle-execute-sql tool interface to match source signature ([#2627](googleapis/mcp-toolbox#2627)) ([81699a3](googleapis/mcp-toolbox@81699a3)) * Return AllParams for GetParameter() for tools with templateParameter([#2734](googleapis/mcp-toolbox#2734)) ([bfd7ba6](googleapis/mcp-toolbox@bfd7ba6)) * **server/mcp:** Scope defer span.End inside loop iteration ([#2558](googleapis/mcp-toolbox#2558)) ([c88a62d](googleapis/mcp-toolbox@c88a62d)), closes [#2549](googleapis/mcp-toolbox#2549) * **skill:** Fix env variable propagation ([#2645](googleapis/mcp-toolbox#2645)) ([5271368](googleapis/mcp-toolbox@5271368)) * **sources/looker:** Looker and looker-dev prebuilt tools should share one source definition. ([#2620](googleapis/mcp-toolbox#2620)) ([df7f2fd](googleapis/mcp-toolbox@df7f2fd)) * **telemetry:** Histogram buckets from OTel standard to MCP standards ([#2729](googleapis/mcp-toolbox#2729)) ([87cd4a0](googleapis/mcp-toolbox@87cd4a0)) * **ui:** Remove module from script ([#2703](googleapis/mcp-toolbox#2703)) ([6943ab6](googleapis/mcp-toolbox@6943ab6)) * Update toolset attributes naming ([#2554](googleapis/mcp-toolbox#2554)) ([3d6ae4e](googleapis/mcp-toolbox@3d6ae4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

## Description Fix: Fixed the flakiness in the list locks integration test for postgres ``` go test -tags=integration tests/postgres/postgres_integration_test.go ok command-line-arguments 14.392s ``` ## PR Checklist - [X] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [X] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [X] Ensure the tests and linter pass - [X] Code coverage does not decrease (if any source code was changed) - [X] Appropriate docs were updated (if necessary) - [X] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1738

🤖 I have created a release *beep* *boop* --- ## [0.29.0](googleapis/mcp-toolbox@v0.28.0...v0.29.0) (2026-03-13) ### ⚠ BREAKING CHANGES * **source/alloydb:** restructure prebuilt toolsets ([googleapis#2639](googleapis#2639)) * **source/spanner:** restructure prebuilt toolsets ([googleapis#2641](googleapis#2641)) * **source/dataplex:** restructure prebuilt toolsets ([googleapis#2640](googleapis#2640)) * **source/oss-db:** restructure prebuilt toolsets ([googleapis#2638](googleapis#2638)) * **source/cloudsql:** restructure prebuilt toolsets ([googleapis#2635](googleapis#2635)) * **source/bigquery:** restructure prebuilt toolsets ([googleapis#2637](googleapis#2637)) * **source/firestore:** restructure prebuilt toolsets ([googleapis#2636](googleapis#2636)) * telemetry metrics updates as per semantic convention ([googleapis#2566](googleapis#2566)) ### Features * Add user agent to embeddings generation ([googleapis#2572](googleapis#2572)) ([287251a](googleapis@287251a)) * **skill:** Attach user agent metadata for generated skill ([googleapis#2697](googleapis#2697)) ([9598a6a](googleapis@9598a6a)) * **skills:** Add additional-notes flag to generate skills command ([googleapis#2696](googleapis#2696)) ([73bf962](googleapis@73bf962)) * **skill:** Update skill generation logic ([googleapis#2646](googleapis#2646)) ([c233eee](googleapis@c233eee)) * **source/alloydb:** Restructure prebuilt toolsets ([googleapis#2639](googleapis#2639)) ([5f3f063](googleapis@5f3f063)) * **source/bigquery:** Restructure prebuilt toolsets ([googleapis#2637](googleapis#2637)) ([dc984ba](googleapis@dc984ba)) * **sources/bigquery:** Support custom oauth header name ([googleapis#2564](googleapis#2564)) ([d3baf77](googleapis@d3baf77)) * **source/cloudsql:** Restructure prebuilt toolsets ([googleapis#2635](googleapis#2635)) ([99613dc](googleapis@99613dc)) * **source/dataplex:** Restructure prebuilt toolsets ([googleapis#2640](googleapis#2640)) ([acb9a80](googleapis@acb9a80)) * **source/firestore:** Restructure prebuilt toolsets ([googleapis#2636](googleapis#2636)) ([22ab7b9](googleapis@22ab7b9)) * **source/oss-db:** Restructure prebuilt toolsets ([googleapis#2638](googleapis#2638)) ([5196c6a](googleapis@5196c6a)) * **source/spanner:** Restructure prebuilt toolsets ([googleapis#2641](googleapis#2641)) ([ea2b698](googleapis@ea2b698)) * Telemetry metrics updates as per semantic convention ([googleapis#2566](googleapis#2566)) ([131d764](googleapis@131d764)) * **tools/mongodb:** Add tool annotations to MongoDB tools for improved LLM understanding ([googleapis#2219](googleapis#2219)) ([b7a5f80](googleapis@b7a5f80)) * **tools/serverless-spark:** Add get_session_template tool ([googleapis#2308](googleapis#2308)) ([a136e16](googleapis@a136e16)) * **tools/serverless-spark:** Add list/get sessions tools ([googleapis#2576](googleapis#2576)) ([a554298](googleapis@a554298)) ### Bug Fixes * Improve list locks integration test for postgres ([googleapis#2279](googleapis#2279)) ([d9ebe5d](googleapis@d9ebe5d)) * **mcp:** Guard nil SSE session lookup and return 400 for missing session ([googleapis#2681](googleapis#2681)) ([f66189f](googleapis@f66189f)) * **oracle:** Update oracle-execute-sql tool interface to match source signature ([googleapis#2627](googleapis#2627)) ([81699a3](googleapis@81699a3)) * Return AllParams for GetParameter() for tools with templateParameter([googleapis#2734](googleapis#2734)) ([bfd7ba6](googleapis@bfd7ba6)) * **server/mcp:** Scope defer span.End inside loop iteration ([googleapis#2558](googleapis#2558)) ([c88a62d](googleapis@c88a62d)), closes [googleapis#2549](googleapis#2549) * **skill:** Fix env variable propagation ([googleapis#2645](googleapis#2645)) ([5271368](googleapis@5271368)) * **sources/looker:** Looker and looker-dev prebuilt tools should share one source definition. ([googleapis#2620](googleapis#2620)) ([df7f2fd](googleapis@df7f2fd)) * **telemetry:** Histogram buckets from OTel standard to MCP standards ([googleapis#2729](googleapis#2729)) ([87cd4a0](googleapis@87cd4a0)) * **ui:** Remove module from script ([googleapis#2703](googleapis#2703)) ([6943ab6](googleapis@6943ab6)) * Update toolset attributes naming ([googleapis#2554](googleapis#2554)) ([3d6ae4e](googleapis@3d6ae4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>

ravisiddhu requested a review from a team January 8, 2026 13:37

blunderbuss-gcf Bot assigned duwenxin99 Jan 8, 2026

gemini-code-assist Bot reviewed Jan 8, 2026

View reviewed changes

Comment thread tests/tool.go

duwenxin99 reviewed Jan 8, 2026

View reviewed changes

Comment thread tests/tool.go Outdated

ravisiddhu force-pushed the pg-list-locks-fix branch from cbc97c4 to 19395c6 Compare January 8, 2026 17:37

fix: improve list locks integration test for postgres

bea340f

ravisiddhu force-pushed the pg-list-locks-fix branch from 19395c6 to bea340f Compare January 8, 2026 17:39

ravisiddhu added the tests: run Label to trigger Github Action tests. label Jan 8, 2026

github-actions Bot removed the tests: run Label to trigger Github Action tests. label Jan 8, 2026

duwenxin99 approved these changes Jan 8, 2026

View reviewed changes

ravisiddhu added 2 commits January 9, 2026 11:24

Merge branch 'main' into pg-list-locks-fix

55aaf34

Merge branch 'googleapis:main' into pg-list-locks-fix

764d3d3

ravisiddhu enabled auto-merge (squash) January 16, 2026 04:13

ravisiddhu added the tests: run Label to trigger Github Action tests. label Jan 16, 2026

github-actions Bot removed the tests: run Label to trigger Github Action tests. label Jan 16, 2026

ravisiddhu and others added 3 commits January 16, 2026 16:18

Merge branch 'main' into pg-list-locks-fix

9cb4143

Merge branch 'main' into pg-list-locks-fix

1ee530b

Merge branch 'main' into pg-list-locks-fix

c2d1219

duwenxin99 changed the title ~~fix: improve list locks integration test for postgres~~ ci(postgres): improve list locks integration test for postgres Feb 3, 2026

Merge branch 'main' into pg-list-locks-fix

9848892

duwenxin99 added the tests: run Label to trigger Github Action tests. label Feb 4, 2026

github-actions Bot removed the tests: run Label to trigger Github Action tests. label Feb 4, 2026

duwenxin99 and others added 5 commits February 4, 2026 16:28

Merge branch 'main' into pg-list-locks-fix

ed7438e

Merge branch 'main' into pg-list-locks-fix

b478fa9

Merge branch 'main' into pg-list-locks-fix

707136f

Merge branch 'main' into pg-list-locks-fix

351bc04

Merge branch 'main' into pg-list-locks-fix

8fd21a6

Yuan325 added the release candidate Use label to signal PR should be included in the next release. label Feb 24, 2026

Merge branch 'main' into pg-list-locks-fix

279d867

averikitsch requested a review from a team as a code owner March 4, 2026 19:45

Merge branch 'main' into pg-list-locks-fix

d55f0e8

averikitsch added the tests: run Label to trigger Github Action tests. label Mar 4, 2026

github-actions Bot removed the tests: run Label to trigger Github Action tests. label Mar 4, 2026

Merge branch 'main' into pg-list-locks-fix

4e4735a

Yuan325 added the tests: run Label to trigger Github Action tests. label Mar 12, 2026

ravisiddhu merged commit d9ebe5d into googleapis:main Mar 12, 2026
15 checks passed

release-please Bot mentioned this pull request Mar 12, 2026

chore(main): release 0.29.0 #2608

Merged

BrewTestBot mentioned this pull request Mar 13, 2026

mcp-toolbox 0.29.0 Homebrew/homebrew-core#272217

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(postgres): improve list locks integration test for postgres#2279

ci(postgres): improve list locks integration test for postgres#2279
ravisiddhu merged 15 commits intogoogleapis:mainfrom
ravisiddhu:pg-list-locks-fix

ravisiddhu commented Jan 8, 2026 •

edited by rahulpinto19

Loading

Uh oh!

gemini-code-assist Bot commented Jan 8, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

duwenxin99 commented Feb 19, 2026

Uh oh!

averikitsch commented Mar 4, 2026

Uh oh!

Yuan325 commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ravisiddhu commented Jan 8, 2026 • edited by rahulpinto19 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

PR Checklist

Uh oh!

gemini-code-assist Bot commented Jan 8, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

duwenxin99 commented Feb 19, 2026

Uh oh!

averikitsch commented Mar 4, 2026

Uh oh!

Yuan325 commented Mar 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ravisiddhu commented Jan 8, 2026 •

edited by rahulpinto19

Loading