Skip to content

Commit bfd7ba6

Browse files
authored
fix: return AllParams for GetParameter() (#2734)
Fixes for some tools that did not return `t.AllParams` for the `GetParameters()` when template parameter exists. 🛠️ Fixes #2720
1 parent 7cea666 commit bfd7ba6

9 files changed

Lines changed: 9 additions & 9 deletions

File tree

internal/tools/bigquery/bigquerysql/bigquerysql.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,5 +251,5 @@ func (t Tool) GetAuthTokenHeaderName(resourceMgr tools.SourceProvider) (string,
251251
}
252252

253253
func (t Tool) GetParameters() parameters.Parameters {
254-
return t.Parameters
254+
return t.AllParams
255255
}

internal/tools/bigtable/bigtable.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,5 +147,5 @@ func (t Tool) GetAuthTokenHeaderName(resourceMgr tools.SourceProvider) (string,
147147
}
148148

149149
func (t Tool) GetParameters() parameters.Parameters {
150-
return t.Parameters
150+
return t.AllParams
151151
}

internal/tools/clickhouse/clickhousesql/clickhousesql.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,5 +139,5 @@ func (t Tool) GetAuthTokenHeaderName(resourceMgr tools.SourceProvider) (string,
139139
}
140140

141141
func (t Tool) GetParameters() parameters.Parameters {
142-
return t.Parameters
142+
return t.AllParams
143143
}

internal/tools/oceanbase/oceanbasesql/oceanbasesql.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,5 +152,5 @@ func (t Tool) GetAuthTokenHeaderName(resourceMgr tools.SourceProvider) (string,
152152
}
153153

154154
func (t Tool) GetParameters() parameters.Parameters {
155-
return t.Parameters
155+
return t.AllParams
156156
}

internal/tools/oracle/oraclesql/oraclesql.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,5 +149,5 @@ func (t Tool) GetAuthTokenHeaderName(resourceMgr tools.SourceProvider) (string,
149149
}
150150

151151
func (t Tool) GetParameters() parameters.Parameters {
152-
return t.Parameters
152+
return t.AllParams
153153
}

internal/tools/snowflake/snowflakesql/snowflakesql.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,5 +149,5 @@ func (t Tool) GetAuthTokenHeaderName(resourceMgr tools.SourceProvider) (string,
149149
}
150150

151151
func (t Tool) GetParameters() parameters.Parameters {
152-
return t.Parameters
152+
return t.AllParams
153153
}

internal/tools/sqlite/sqlitesql/sqlitesql.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,5 +147,5 @@ func (t Tool) GetAuthTokenHeaderName(resourceMgr tools.SourceProvider) (string,
147147
}
148148

149149
func (t Tool) GetParameters() parameters.Parameters {
150-
return t.Parameters
150+
return t.AllParams
151151
}

internal/tools/trino/trinosql/trinosql.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,5 +147,5 @@ func (t Tool) GetAuthTokenHeaderName(resourceMgr tools.SourceProvider) (string,
147147
}
148148

149149
func (t Tool) GetParameters() parameters.Parameters {
150-
return t.Parameters
150+
return t.AllParams
151151
}

internal/tools/yugabytedbsql/yugabytedbsql.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,5 +148,5 @@ func (t Tool) GetAuthTokenHeaderName(resourceMgr tools.SourceProvider) (string,
148148
}
149149

150150
func (t Tool) GetParameters() parameters.Parameters {
151-
return t.Parameters
151+
return t.AllParams
152152
}

0 commit comments

Comments
 (0)