fix(oracle): update oracle-execute-sql tool interface to match source signature (#2627)

anubhav756 · web-flow · commit 81699a375b7e · 2026-03-07T00:22:50.000+05:30
## Description This PR fixes a critical signature mismatch that caused all `oracle-execute-sql` tool invocations to fail with an incompatible source type error (`500` Internal Server Error). In a previous PR (#2323), the `RunSQL` method in the Oracle Source was updated to include a `readOnly` bool parameter to support DML operations for the `oracle-sql` tool: However, the `oracle-execute-sql` tool's required interface (`compatibleSource`) was inadvertently left unchanged, still expecting the old 3-argument signature. Because Go interfaces are satisfied implicitly, the updated Oracle source no longer implemented the `oracle-execute-sql` tool's interface, causing `tools.GetCompatibleSource` to reject it at runtime during invocation. 🛠️ Fixes #2614
diff --git a/internal/tools/oracle/oracleexecutesql/oracleexecutesql.go b/internal/tools/oracle/oracleexecutesql/oracleexecutesql.go
@@ -34,14 +34,15 @@ func newConfig(ctx context.Context, name string, decoder *yaml.Decoder) (tools.T
 
 type compatibleSource interface {
 	OracleDB() *sql.DB
-	RunSQL(context.Context, string, []any) (any, error)
+	RunSQL(context.Context, string, []any, bool) (any, error)
 }
 
 type Config struct {
 	Name         string   `yaml:"name" validate:"required"`
 	Type         string   `yaml:"type" validate:"required"`
 	Source       string   `yaml:"source" validate:"required"`
 	Description  string   `yaml:"description" validate:"required"`
+	ReadOnly     *bool    `yaml:"readOnly"`
 	AuthRequired []string `yaml:"authRequired"`
 }
 
@@ -96,7 +97,13 @@ func (t Tool) Invoke(ctx context.Context, resourceMgr tools.SourceProvider, para
 		return nil, util.NewClientServerError("error getting logger", http.StatusInternalServerError, err)
 	}
 	logger.DebugContext(ctx, "executing `%s` tool query: %s", resourceType, sqlParam)
-	resp, err := source.RunSQL(ctx, sqlParam, nil)
+
+	isReadOnly := true
+	if t.ReadOnly != nil {
+		isReadOnly = *t.ReadOnly
+	}
+
+	resp, err := source.RunSQL(ctx, sqlParam, nil, isReadOnly)
 	if err != nil {
 		return nil, util.ProcessGeneralError(err)
 	}
diff --git a/internal/tools/oracle/oracleexecutesql/oracleexecutesql_test.go b/internal/tools/oracle/oracleexecutesql/oracleexecutesql_test.go
@@ -16,6 +16,9 @@ func TestParseFromYamlOracleExecuteSql(t *testing.T) {
 	if err != nil {
 		t.Fatalf("unexpected error: %s", err)
 	}
+
+	valTrue := true
+	valFalse := false
 	tcs := []struct {
 		desc string
 		in   string
@@ -61,6 +64,48 @@ func TestParseFromYamlOracleExecuteSql(t *testing.T) {
 				},
 			},
 		},
+		{
+			desc: "example with explicit readOnly true",
+			in: `
+            kind: tools
+            name: safe_query
+            type: oracle-execute-sql
+            source: db-prod
+            description: Safe read operation.
+            readOnly: true
+            `,
+			want: server.ToolConfigs{
+				"safe_query": oracleexecutesql.Config{
+					Name:         "safe_query",
+					Type:         "oracle-execute-sql",
+					Source:       "db-prod",
+					Description:  "Safe read operation.",
+					ReadOnly:     &valTrue,
+					AuthRequired: []string{},
+				},
+			},
+		},
+		{
+			desc: "example with explicit readOnly false (DML)",
+			in: `
+            kind: tools
+            name: update_user
+            type: oracle-execute-sql
+            source: db-prod
+            description: Updates user table.
+            readOnly: false
+            `,
+			want: server.ToolConfigs{
+				"update_user": oracleexecutesql.Config{
+					Name:         "update_user",
+					Type:         "oracle-execute-sql",
+					Source:       "db-prod",
+					Description:  "Updates user table.",
+					ReadOnly:     &valFalse,
+					AuthRequired: []string{},
+				},
+			},
+		},
 	}
 	for _, tc := range tcs {
 		t.Run(tc.desc, func(t *testing.T) {
