Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

feat: Sum and Avg aggregation feature#1067

Merged
kolea2 merged 28 commits intogoogleapis:mainfrom
jainsahab:sum-avg-feature
Aug 22, 2023
Merged

feat: Sum and Avg aggregation feature#1067
kolea2 merged 28 commits intogoogleapis:mainfrom
jainsahab:sum-avg-feature

Conversation

@jainsahab
Copy link
Copy Markdown
Contributor

@jainsahab jainsahab commented May 8, 2023

Add support for querying the mathematical SUM and AVERAGE of an entity's specific field chosen by user.

@jainsahab jainsahab requested review from a team May 8, 2023 11:14
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: datastore Issues related to the googleapis/java-datastore API. labels May 8, 2023
kolea2
kolea2 suggested changes May 12, 2023
View reviewed changes
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationQuery.java
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationResult.java
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/aggregation/AvgAggregation.java
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/aggregation/AvgAggregation.java
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/aggregation/AvgAggregation.java Outdated
Comment thread google-cloud-datastore/src/test/java/com/google/cloud/datastore/AggregationQueryTest.java Outdated
Comment thread ...cloud-datastore/src/test/java/com/google/cloud/datastore/aggregation/AvgAggregationTest.java
Comment thread ...cloud-datastore/src/test/java/com/google/cloud/datastore/aggregation/SumAggregationTest.java
Comment thread ...a/com/google/cloud/datastore/execution/response/AggregationQueryResponseTransformerTest.java Outdated
Comment thread ...cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITDatastoreAggregationsTest.java
@kolea2 kolea2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 12, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels May 15, 2023
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels May 18, 2023
kolea2
kolea2 reviewed May 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking really good!

Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationQuery.java
@jainsahab jainsahab mentioned this pull request Jun 6, 2023
Merged
@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 18, 2023
@meredithslota meredithslota added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 18, 2023
meltsufin
meltsufin reviewed Aug 18, 2023
View reviewed changes
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationResult.java Outdated
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationResult.java Outdated
Comment thread google-cloud-datastore/src/main/java/com/google/cloud/datastore/AggregationResult.java Outdated
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 21, 2023
@kolea2 kolea2 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 22, 2023
@kolea2 kolea2 merged commit 56d1001 into googleapis:main Aug 22, 2023
@release-please release-please bot mentioned this pull request Aug 19, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@burkedavison burkedavison burkedavison left review comments

@meltsufin meltsufin meltsufin approved these changes

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jainsahab @meltsufin @burkedavison @kolea2 @meredithslota