Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

feat: Support RANGE schema#3043

Merged
PhongChuong merged 6 commits intomainfrom
rangeSchemaSupport
Jan 5, 2024
Merged

feat: Support RANGE schema#3043
PhongChuong merged 6 commits intomainfrom
rangeSchemaSupport

Conversation

@PhongChuong
Copy link
Copy Markdown
Contributor

@PhongChuong PhongChuong commented Dec 13, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3042 ☕️

@PhongChuong PhongChuong requested review from a team and farhan0102 December 13, 2023 20:40
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Dec 13, 2023
@PhongChuong PhongChuong changed the title Range schema support feat: Support RANGE schema Dec 13, 2023
@PhongChuong PhongChuong requested review from a team, Linchin and shollyman December 13, 2023 20:42
shollyman
shollyman approved these changes Jan 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a couple of minor docs items.

Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/FieldElementType.java Outdated
Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/LegacySQLTypeName.java Outdated
Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/StandardSQLTypeName.java Outdated
@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jan 5, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 5, 2024
@PhongChuong PhongChuong merged commit febfc1f into main Jan 5, 2024
@PhongChuong PhongChuong deleted the rangeSchemaSupport branch January 5, 2024 16:38
@PhongChuong
Copy link
Copy Markdown
Contributor Author

PhongChuong commented Jan 5, 2024

Thank you for the review.

@release-please release-please bot mentioned this pull request Jan 5, 2024
Merged
This was referenced Jan 17, 2024
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@farhan0102 farhan0102 Awaiting requested review from farhan0102

@Linchin Linchin Awaiting requested review from Linchin

1 more reviewer

@shollyman shollyman shollyman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support RANGE schema

3 participants

@PhongChuong @shollyman @yoshi-kokoro