Skip to content

feat: updates UserAuthorizer to support retrieving token response directly with different client auth types#1486

Merged
lsirac merged 8 commits intogoogleapis:mainfrom
lsirac:userauthorizer
Sep 5, 2024
Merged

feat: updates UserAuthorizer to support retrieving token response directly with different client auth types#1486
lsirac merged 8 commits intogoogleapis:mainfrom
lsirac:userauthorizer

Conversation

@lsirac
Copy link
Copy Markdown
Contributor

@lsirac lsirac commented Aug 28, 2024 •
edited
Loading

Adds support for the following in UserAuthorizer:

  • Different client auth types
  • A method to retrieve the token response directly, not UserCredentials, allowing for it to be used in more ways (e.g. enables Workforce Identity Federation)
  • Constructor now takes in the Builder directly

@lsirac lsirac requested a review from a team August 28, 2024 19:39
@product-auto-label product-auto-label Bot added the size: xl Pull request size is extra large. label Aug 28, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 28, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lsirac lsirac requested a review from aeitzman August 28, 2024 19:57
aeitzman
aeitzman approved these changes Aug 28, 2024
View reviewed changes
Comment thread oauth2_http/java/com/google/auth/oauth2/OAuth2Utils.java Outdated
Comment thread oauth2_http/java/com/google/auth/oauth2/UserAuthorizer.java
@lsirac lsirac requested review from a team and lqiu96 September 3, 2024 22:12
@lqiu96 lqiu96 requested a review from zhumin8 September 4, 2024 14:29
lqiu96
lqiu96 reviewed Sep 4, 2024
View reviewed changes
Comment thread oauth2_http/java/com/google/auth/oauth2/OAuth2Utils.java Outdated
lqiu96
lqiu96 reviewed Sep 4, 2024
View reviewed changes
Comment thread oauth2_http/java/com/google/auth/oauth2/UserAuthorizer.java Outdated
lqiu96
lqiu96 reviewed Sep 4, 2024
View reviewed changes
Comment thread oauth2_http/javatests/com/google/auth/oauth2/OAuth2UtilsTest.java
sai-sunder-s
sai-sunder-s approved these changes Sep 5, 2024
View reviewed changes
Comment thread oauth2_http/java/com/google/auth/oauth2/UserAuthorizer.java
@lsirac lsirac requested a review from lqiu96 September 5, 2024 10:28
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

lqiu96
lqiu96 reviewed Sep 5, 2024
View reviewed changes
Comment thread oauth2_http/java/com/google/auth/oauth2/UserAuthorizer.java
@lqiu96
Copy link
Copy Markdown
Member

lqiu96 commented Sep 5, 2024

Thanks @lsirac, LGTM. Added some last comment if you could take a look as well.

@lsirac lsirac merged commit 1651006 into googleapis:main Sep 5, 2024
@release-please release-please Bot mentioned this pull request Sep 5, 2024
Merged
@release-please release-please Bot mentioned this pull request Dec 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

@zhumin8 zhumin8 Awaiting requested review from zhumin8

+2 more reviewers

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

@aeitzman aeitzman aeitzman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lsirac @lqiu96 @sai-sunder-s @aeitzman