Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/google-auth-library-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.32.1
Choose a base ref
...
head repository: googleapis/google-auth-library-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.33.0
Choose a head ref
  • 13 commits
  • 33 files changed
  • 4 contributors

Commits on Feb 7, 2025

  1. chore(main): release 1.32.2-SNAPSHOT (#1667)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] authored Feb 7, 2025
    Configuration menu
    Copy the full SHA
    2944361 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2025

  1. Configuration menu
    Copy the full SHA
    04e0ee9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96a5ad8 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2025

  1. Configuration menu
    Copy the full SHA
    e4f1849 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3acdf67 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2025

  1. Configuration menu
    Copy the full SHA
    a8fe21f View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2025

  1. Configuration menu
    Copy the full SHA
    37d2284 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2025

  1. Configuration menu
    Copy the full SHA
    54b4c1a View commit details
    Browse the repository at this point in the history
  2. feat: add client logging with slf4j (#1586)

    This Pr contains changes for adding client logging capability to auth.
    see [go/java-client-logging-design](http://goto.google.com/java-client-logging-design)
    
    Some logging setups are mirror of same setting in Gax ([pr 3403](googleapis/sdk-platform-java#3403))
    
    Changes includes:
    - add slf4j as optional dependency, enable logging only when GOOGLE_SDK_JAVA_LOGGING=true
    - user app should add SLF4J + binding dependencies accordingly. For SLF4J 1x, we record extra info with MDC; for SLF4J2x, we record extra info with KeyValuePairs. More user guide to be added via README (see [draft](https://docs.google.com/document/d/1g8HJCstkEEZZc73gFlQO8uPGs07SkWKkr7NG-Yg4bvM/edit?tab=t.0#heading=h.9t58aw3up7to)). 
    - If env var not true, or no binding present, default to no-op.
    - Add log for request and response made to auth endpoints for UserCredentials, ServiceAccountCredentials, ComputeEngineCredentials, ImpersonatedCredentials. For token values included, added hash in log. Note this PR mainly focuses on adding logging setups, logging statements can be added incrementally later if necessary.
    
    
    Here is an example logging output for access token request from UserCredentials when DEBUG level is allowed. (TO UPDATE)
    
    ```
    {"@timestamp":"2024-12-04T21:10:48.596382834-05:00","@Version":"1","message":"Sending auth request to refresh access token.","logger_name":"com.google.auth.oauth2.UserCredentials","thread_name":"main","severity":"DEBUG","level_value":10000,"request.method":"POST","request.headers":{"x-goog-api-client":"gl-java/19.0.1 auth/1.32.2-SNAPSHOT cred-type/u","accept-encoding":["gzip"]},"request.url":"https://foo.com/bar","request.payload":{"refresh_token":"bae0258be92ea1d1e14f984507bee05ff4502a29104f4101d22a4a88706b0fc0","grant_type":"refresh_token","client_secret":"2d3c802ef65d75e88b098792e2268cd3f55a08bcbb8c8c4672f1195d1951d4b5","client_id":"ya29.1.AADtN_UtlxN3PuGAxrN2XQnZTVRvDyVWnYq4I6dws"}}
    {"@timestamp":"2024-12-04T21:10:48.624914522-05:00","@Version":"1","message":"Received auth respond for refresh access token.","logger_name":"com.google.auth.oauth2.UserCredentials","thread_name":"main","severity":"INFO","level_value":20000,"response.status":"200","response.headers":"{}"}
    {"@timestamp":"2024-12-04T21:10:48.627483862-05:00","@Version":"1","message":"Auth response payload.","logger_name":"com.google.auth.oauth2.UserCredentials","thread_name":"main","severity":"DEBUG","level_value":10000,"access_token":"1/MkS*****KPY2","refresh_token":"1/Tl6*****yGWY","token_type":"Bearer","expires_in":"3600"}
    ```
    
    Testing setup -  Currently added flavor of tests: 
    - unit tests with no extra dependency
    - unit tests depending on either binding be present, or logback implementation to capture logging for test
    - test for log behaviors for various requests where logs are added. (see LoggingTest)
    
    Remaining issue with test scenarios: 
    1. when no binding present: this is tested via regular tests
    2.  when env var is T and binding present: tested via test-logging (profile with logback deps)
    3. no SLF4J present: same logic as 1, it should be fine with coverage of 1. This is hard to setup this because SLF4J is needed at compile.
    4. SLF4J 1x + binding: Hard to setup because SLF4J 2x is needed at compile
    zhumin8 authored Feb 24, 2025
    Configuration menu
    Copy the full SHA
    24761d6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    13506ed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7a3df44 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8c6bd4a View commit details
    Browse the repository at this point in the history
  6. chore(main): release 1.33.0 (#1679)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    Co-authored-by: ldetmer <1771267+ldetmer@users.noreply.github.com>
    release-please[bot] and ldetmer authored Feb 24, 2025
    Configuration menu
    Copy the full SHA
    a27c501 View commit details
    Browse the repository at this point in the history
Loading