Skip to content

Rename $Gson$Preconditions and $Gson$Types.#2838

Merged
eamonnmcmanus merged 1 commit intogoogle:mainfrom
eamonnmcmanus:dollar
Apr 6, 2025
Merged

Rename $Gson$Preconditions and $Gson$Types.#2838
eamonnmcmanus merged 1 commit intogoogle:mainfrom
eamonnmcmanus:dollar

Conversation

@eamonnmcmanus
Copy link
Copy Markdown
Member

@eamonnmcmanus eamonnmcmanus commented Apr 5, 2025

There might have been good reasons to use these weird names back in the day, but they cause problems now and there doesn't seem to be a compelling reason to avoid the more obvious names GsonPreconditions and GsonTypes.

Closes #1745. Fixes #1744.

There might have been good reasons to use these weird names back in the
day, but they cause problems and there doesn't seem to be a compelling
reason to avoid the more obvious names `GsonPreconditions` and
`GsonTypes`.
Copy link
Copy Markdown
Member

@kluever kluever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L$G$T$M

@eamonnmcmanus eamonnmcmanus merged commit 45e5e14 into google:main Apr 6, 2025
11 checks passed
@eamonnmcmanus eamonnmcmanus deleted the dollar branch April 6, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename internal Gson classes containing $

2 participants