Skip to content

Replace short field names with more descriptive ones.#937

Merged
pjbgf merged 1 commit intogo-git:masterfrom
matejrisek:feature/rename-short-fields
Mar 16, 2024
Merged

Replace short field names with more descriptive ones.#937
pjbgf merged 1 commit intogo-git:masterfrom
matejrisek:feature/rename-short-fields

Conversation

@matejrisek
Copy link
Copy Markdown
Contributor

@matejrisek matejrisek commented Nov 19, 2023 •
edited
Loading

The decision to change the name of these fields came from reading the code further down in the scope and not being clear what c.c means.

This also aligns it with the convention from other structs in the same file like e.g. the session struct:

type session struct {
	auth     AuthMethod
	client   *http.Client
	endpoint *transport.Endpoint
	advRefs  *packp.AdvRefs
}

@matejrisek
plumbing: Replace short field names with more descriptive ones.
dcf0639 
The decision to change the name of these fields came from reading the code
further down in the scope and not being clear what `c.c` means.
@matejrisek matejrisek force-pushed the feature/rename-short-fields branch from 216899b to dcf0639 Compare November 19, 2023 15:46
pjbgf
pjbgf approved these changes Mar 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matejrisek! 🙇

@pjbgf pjbgf merged commit feaeb36 into go-git:master Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pjbgf pjbgf pjbgf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matejrisek @pjbgf