openapi3: strip __origin__ from extension values to prevent spurious diffs#1137
Merged
fenollp merged 1 commit intogetkin:masterfrom Mar 31, 2026
Merged
Conversation
959f841 to
d0253c3
Compare
Extension values are map[string]any, so the YAML decoder injects __origin__ into them. Without stripping it, two specs loaded from different file paths produce different extension values, causing spurious diffs. Call stripExtensionsOrigin after delete(Extensions, originKey) in all 21 UnmarshalJSON implementations, including the root T type. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
d0253c3 to
f24dfea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
map[string]any, so the YAML decoder injects__origin__into themstripExtensionsOriginhelper inorigin.goand calls it afterdelete(Extensions, originKey)in all 21UnmarshalJSONimplementations, including the rootTtypeTest plan
TestOrigin_ExtensionValuesStripped— verifies__origin__is stripped from both root (T) and nested (Info) extension object valuesgo test ./...🤖 Generated with Claude Code