remove text-decoding - #120
Merged
Merged
Conversation
Contributor
|
It was for Backwards compatibility. |
Uzlopak
approved these changes
Aug 13, 2023
Uzlopak
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Added semver major label.
Member
|
@KhafraDev @Uzlopak wasn't it for compatibility with non-node runtimes, such as AtlasDB workers? |
Member
|
no, #100 seems to be a different thing |
Uzlopak
requested changes
Aug 13, 2023
Uzlopak
left a comment
Contributor
There was a problem hiding this comment.
Blocking till we investigate or come to a conclusion on how to avoid breaking too much
Contributor
|
Talked with kibertoad. The issue with firebase_admin was that dicer does not need the TextDecoder. And this PR should not break firebase_admin. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in #50 for reasons I don't really understand. According to the PR node's TextDecoder is the fastest (and I assume it's even faster now), provides the same features, and is available globally since node v11.