[Fizz] Don't perform work when closing#30497
Merged
gnoff merged 1 commit intofacebook:mainfrom Jul 29, 2024
Merged
Conversation
When a Fizz render is closing but not yet closed it's possible that pinged tasks can spawn more work. The point of the closing state is to allow time to start piping/reading the underlying stream but semantically the render is finished at that point so work should no longer happen.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: a6b5ed01ae98a18507cb92d8e932a8ca321602e6...029d671ff97ac627dd39444dcea1f7f9ac26486d Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Jul 29, 2024
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
When a Fizz render is closing but not yet closed it's possible that pinged tasks can spawn more work. The point of the closing state is to allow time to start piping/reading the underlying stream but semantically the render is finished at that point so work should no longer happen. DiffTrain build for [9938e24](9938e24)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Fizz render is closing but not yet closed it's possible that pinged tasks can spawn more work. The point of the closing state is to allow time to start piping/reading the underlying stream but semantically the render is finished at that point so work should no longer happen.