Feature flag to disable legacy context for function components#30319
Merged
kassens merged 1 commit intofacebook:mainfrom Jul 11, 2024
Merged
Feature flag to disable legacy context for function components#30319kassens merged 1 commit intofacebook:mainfrom
kassens merged 1 commit intofacebook:mainfrom
Conversation
While the goal is to remove legacy context completely, I think we can already land the removal of legacy context for function components. I didn't even know this feature existed until reading the code recently. The win is just a couple of property lookups on function renders, but it trims down the API already as the full removal will likely still take a bit more time. www: Starting with enabled test renderer and a feature flag for production rollout. RN: Not enabled, will follow up on this.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yungsters
approved these changes
Jul 11, 2024
Contributor
yungsters
left a comment
There was a problem hiding this comment.
Didn't want to name it like the other flag, "ForNonClassComponents"? 😅
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
While the goal is to remove legacy context completely, I think we can already land the removal of legacy context for function components. I didn't even know this feature existed until reading the code recently. The win is just a couple of property lookups on function renders, but it trims down the API already as the full removal will likely still take a bit more time. www: Starting with enabled test renderer and a feature flag for production rollout. RN: Not enabled, will follow up on this. DiffTrain build for [af28f48](af28f48)
This was referenced Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the goal is to remove legacy context completely, I think we can already land the removal of legacy context for function components. I didn't even know this feature existed until reading the code recently.
The win is just a couple of property lookups on function renders, but it trims down the API already as the full removal will likely still take a bit more time.
www: Starting with enabled test renderer and a feature flag for production rollout.
RN: Not enabled, will follow up on this.