Skip to content

clean obsolete python 2 code from the ssl module#915

Merged
4383 merged 2 commits intoeventlet:masterfrom
4383:clean-ssl-module
Feb 19, 2024
Merged

clean obsolete python 2 code from the ssl module#915
4383 merged 2 commits intoeventlet:masterfrom
4383:clean-ssl-module

Conversation

@4383
Copy link
Copy Markdown
Member

@4383 4383 commented Feb 13, 2024

The removed code seems obsolete.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06ec630) 56% compared to head (8e6eeb2) 56%.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #915   +/-   ##
=====================================
  Coverage      56%    56%           
=====================================
  Files          89     89           
  Lines        9722   9718    -4     
  Branches     1810   1809    -1     
=====================================
- Hits         5462   5461    -1     
+ Misses       3885   3883    -2     
+ Partials      375    374    -1     
Flag Coverage Δ
ipv6 23% <ø> (+<1%) ⬆️
py310asyncio 53% <ø> (+<1%) ⬆️
py310epolls 53% <ø> (+<1%) ⬆️
py310poll 53% <ø> (+<1%) ⬆️
py310selects 53% <ø> (-1%) ⬇️
py311asyncio 53% <ø> (+<1%) ⬆️
py311epolls 53% <ø> (+<1%) ⬆️
py312asyncio 50% <ø> (+<1%) ⬆️
py312epolls 51% <ø> (+<1%) ⬆️
py37asyncio 50% <ø> (+<1%) ⬆️
py37epolls 51% <ø> (+<1%) ⬆️
py38asyncio 51% <ø> (+<1%) ⬆️
py38epolls 53% <ø> (+<1%) ⬆️
py38openssl 52% <ø> (-1%) ⬇️
py38poll 53% <ø> (+<1%) ⬆️
py38selects 53% <ø> (+<1%) ⬆️
py39asyncio 51% <ø> (+<1%) ⬆️
py39dnspython1 51% <ø> (+<1%) ⬆️
py39epolls 53% <ø> (+<1%) ⬆️
py39poll 53% <ø> (+<1%) ⬆️
py39selects 53% <ø> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4383 4383 requested a review from itamarst February 16, 2024 10:52
@4383 4383 merged commit 96a3940 into eventlet:master Feb 19, 2024
@4383 4383 mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants