Skip to content

wsgi: discard trailers#1062

Merged
4383 merged 1 commit intoeventlet:masterfrom
sebastianosrt:master
Aug 11, 2025
Merged

wsgi: discard trailers#1062
4383 merged 1 commit intoeventlet:masterfrom
sebastianosrt:master

Conversation

@sebastianosrt
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57%. Comparing base (e073b83) to head (c025dea).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1062   +/-   ##
======================================
- Coverage      57%     57%   -1%     
======================================
  Files          89      89           
  Lines        9873    9878    +5     
  Branches     1648    1649    +1     
======================================
- Hits         5672    5658   -14     
- Misses       3842    3872   +30     
+ Partials      359     348   -11     
Flag Coverage Δ
ipv6 23% <16%> (-1%) ⬇️
py310asyncio ?
py310epolls ?
py310poll ?
py310selects ?
py311asyncio 53% <83%> (+<1%) ⬆️
py311epolls ?
py312asyncio 52% <83%> (-1%) ⬇️
py312epolls ?
py313asyncio ?
py313epolls ?
py314asyncio ?
py314epolls 53% <83%> (+<1%) ⬆️
py39asyncio ?
py39dnspython1 51% <80%> (+<1%) ⬆️
py39epolls 53% <80%> (+<1%) ⬆️
py39openssl 51% <80%> (+<1%) ⬆️
py39poll 53% <80%> (+<1%) ⬆️
py39selects ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@4383
Copy link
Copy Markdown
Member

4383 commented Aug 11, 2025

Hello,

Thank you for proposing that change. Just to be sure about the motivation behind this patch, is it to address a request smuggling vulnerability, like the one in aiohttp?

aio-libs/aiohttp@e8d774f

@sebastianosrt
Copy link
Copy Markdown
Contributor Author

Hello, yes exactly. In wsgi, only one line after the final chunk was being read, leaving the trailers in the buffer. I've added logic to continue reading until the last trailer is processed.

@4383
Copy link
Copy Markdown
Member

4383 commented Aug 11, 2025

Thanks for your answer. LGTM. I'm gonna go to merge it and to release it.

@4383 4383 merged commit 0bfebd1 into eventlet:master Aug 11, 2025
24 of 27 checks passed
@openshift-merge-robot
Copy link
Copy Markdown

Fix included in accepted release 4.16.0-0.nightly-2026-01-20-190315

@openshift-merge-robot
Copy link
Copy Markdown

Fix included in accepted release 4.15.0-0.nightly-2026-01-23-004257

@openshift-merge-robot
Copy link
Copy Markdown

Fix included in accepted release 4.15.0-0.nightly-2026-01-23-102229

@openshift-merge-robot
Copy link
Copy Markdown

Fix included in accepted release 4.14.0-0.nightly-2026-01-26-153049

@openshift-merge-robot
Copy link
Copy Markdown

Fix included in accepted release 4.13.0-0.nightly-2026-02-10-163022

@openshift-merge-robot
Copy link
Copy Markdown

Fix included in accepted release 4.12.0-0.nightly-2026-02-19-132245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants