Skip to content

Calling eventlet.sleep(0) isn't really blocking, so don't blow up#1015

Merged
4383 merged 3 commits intomasterfrom
1014-sleep-of-zero-seconds-isnt-blocking
Jan 17, 2025
Merged

Calling eventlet.sleep(0) isn't really blocking, so don't blow up#1015
4383 merged 3 commits intomasterfrom
1014-sleep-of-zero-seconds-isnt-blocking

Conversation

@itamarst
Copy link
Copy Markdown
Contributor

Fixes #1014

The bug report BTW suggests we shouldn't try to make things better, every time we do something breaks 😭

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 55%. Comparing base (3450e6a) to head (52adc25).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
eventlet/greenthread.py 50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1015   +/-   ##
======================================
- Coverage      56%     55%   -1%     
======================================
  Files          89      89           
  Lines        9856    9852    -4     
  Branches     1770    1771    +1     
======================================
- Hits         5578    5479   -99     
- Misses       3914    4001   +87     
- Partials      364     372    +8     
Flag Coverage Δ
ipv6 ?
py310asyncio ?
py310epolls ?
py310poll ?
py310selects ?
py311asyncio ?
py311epolls ?
py312asyncio 51% <50%> (-1%) ⬇️
py312epolls ?
py313asyncio ?
py313epolls ?
py37asyncio ?
py37epolls ?
py38asyncio ?
py38epolls ?
py38openssl ?
py38poll ?
py38selects 53% <50%> (+<1%) ⬆️
py39asyncio ?
py39dnspython1 ?
py39epolls 53% <50%> (+<1%) ⬆️
py39poll ?
py39selects 53% <50%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4383 4383 merged commit fcc5ce4 into master Jan 17, 2025
@4383 4383 deleted the 1014-sleep-of-zero-seconds-isnt-blocking branch January 17, 2025 10:34
@itamarst itamarst mentioned this pull request Jan 17, 2025
openstack-mirroring pushed a commit to openstack/requirements that referenced this pull request Jan 25, 2025
Mostly to introduce:
- eventlet/eventlet#1015
- eventlet/eventlet#999

Change-Id: I29936e8ba38ebc445608b832aad381c2bbf1321f
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Jan 25, 2025
* Update requirements from branch 'master'
  to 85bdde267a48fdaf53e6933a5f81e2bb95c1010b
  - bump to eventlet 0.39.0
    
    Mostly to introduce:
    - eventlet/eventlet#1015
    - eventlet/eventlet#999
    
    Change-Id: I29936e8ba38ebc445608b832aad381c2bbf1321f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

time.sleep(0) or greenthread.sleep(0) is docuemnted as the canonical way of expressing a cooperative yield

3 participants