fix(indent): correctly ignore JSXText and TS nodes#785
Merged
antfu merged 17 commits intoeslint-stylistic:mainfrom Jun 8, 2025
Merged
fix(indent): correctly ignore JSXText and TS nodes#785antfu merged 17 commits intoeslint-stylistic:mainfrom
JSXText and TS nodes#785antfu merged 17 commits intoeslint-stylistic:mainfrom
Conversation
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
==========================================
+ Coverage 99.67% 99.68% +0.01%
==========================================
Files 95 95
Lines 18220 18075 -145
Branches 4659 4663 +4
==========================================
- Hits 18160 18018 -142
+ Misses 60 57 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
antfu
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Some TS nodes used to be wrongly ignored by following
ignoreNodesoption.If you still want to ignore them, please pay attention.
Here are the nodes:
TSAsExpressionBinaryExpressionTSConditionalTypeConditionalExpressionTSEnumDeclarationObjectExpressionTSTypeLiteralObjectExpressionTSImportEqualsDeclarationVariableDeclarationTSIndexedAccessTypeMemberExpressionTSInterfaceBodyClassBodyTSInterfaceDeclarationClassDeclarationTSMappedTypeObjectExpressionTSModuleBlockBlockStatementTSQualifiedNameMemberExpressionTSTupleTypeArrayExpressionTSTypeParameterDeclarationJSXOpeningElementTSTypeParameterInstantiationJSXOpeningElementDescription
Move
JSXTextand TS nodes intobaseOffsetListenersso that they can be ignored correctly by theignoredNodesoption.Linked Issues
fixes #754
Additional context