Conversation
fasttime
approved these changes
Nov 3, 2024
Member
fasttime
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open until Monday in case someone else wants to review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Updates
@eslint/compatutility to support legacyschemaproperty of rules.What changes did you make? (Give an overview)
Updated
fixupRule()to copy top-levelschemaproperty into rule'smetaobject.This covers:
schemaproperty of the function.schemaproperty, which was never officially supported but used to work in ESLint < 9.Related Issues
Fixes #127
I tested this with
eslint-plugin-fpandeslint-plugin-filenamesrules mentioned in the original issue.Is there anything you'd like reviewers to focus on?