feat: Add Directive and DirectiveType#112
Merged
mdjermanovic merged 5 commits intomainfrom Aug 30, 2024
Merged
Conversation
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
We probably also want to re-export Directive here:
rewrite/packages/plugin-kit/src/index.js
Lines 7 to 11 in c95ba1f
Member
Author
|
Oops, correct! |
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Merged
snitin315
pushed a commit
that referenced
this pull request
Mar 29, 2026
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Add
Directiveclass to@eslint/plugin-kit. (Extracted from the core.)What changes did you make? (Give an overview)
Directiveclass to@eslint/plugin-kitto be used when implementingSourceCode#getDisableDirectives()DirectiveTypetype to@eslint/coreDirective#nodeto be typeunknowninstead ofobjectto force consumers to type cast the value before using it.DirectiveRelated Issues
Is there anything you'd like reviewers to focus on?