feat: ignore type annotations in no-restricted-globals#19781
Merged
snitin315 merged 3 commits intoeslint:mainfrom Jun 3, 2025
Merged
feat: ignore type annotations in no-restricted-globals#19781snitin315 merged 3 commits intoeslint:mainfrom
snitin315 merged 3 commits intoeslint:mainfrom
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
nzakas
reviewed
May 28, 2025
Member
nzakas
left a comment
There was a problem hiding this comment.
This is looking good. I just left a few suggestions to clean things up a bit.
snitin315
reviewed
May 28, 2025
nzakas
previously approved these changes
May 29, 2025
Member
nzakas
left a comment
There was a problem hiding this comment.
LGTM, thanks. Would like @snitin315 to verify his feedback has been addressed before merging.
snitin315
previously approved these changes
May 31, 2025
Contributor
snitin315
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Leaving this open until the patch release window.
mdjermanovic
reviewed
Jun 2, 2025
mdjermanovic
approved these changes
Jun 3, 2025
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @nzakas and @snitin315 to verify the latest changes.
nzakas
approved these changes
Jun 3, 2025
Member
nzakas
left a comment
There was a problem hiding this comment.
LGTM pending @snitin315's review.
snitin315
approved these changes
Jun 3, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
This PR modifies the no-restricted-globals rule to ignore restricted globals when they appear in TypeScript type annotations.
Closes #19769
Is there anything you'd like reviewers to focus on?