test: ignore package-lock.json for eslint-webpack-plugin#19572
Merged
test: ignore package-lock.json for eslint-webpack-plugin#19572
package-lock.json for eslint-webpack-plugin#19572Conversation
snitin315
reviewed
Mar 24, 2025
| run: | | ||
| npm install | ||
| npm install ../eslint | ||
| npm install --no-package-lock ../eslint |
Contributor
There was a problem hiding this comment.
Should we use --no-package-lock for other packages as well to avoid such future issues?
Member
Author
There was a problem hiding this comment.
I've added --no-package-lock to the npm install command for neostandard as well. The repos for the other packages don't contain a package-lock.json file.
❌ Deploy Preview for docs-eslint failed. Why did it fail? →
|
✅ Deploy Preview for docs-eslint canceled.
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain: fix type integration tests
This PR fixes an error in type integration tests that has been occurring since the publishing of
@types/estree@1.0.7, e.g.: https://github.com/eslint/eslint/actions/runs/14029899007/job/39275099400. The new version of@types/estree@1.0.7adds a new required property to a type (see DefinitelyTyped/DefinitelyTyped#72206), and this results in an incompatibility with previous versions of the same package.What changes did you make? (Give an overview)
Changed a command in a CI workflow so that
eslint-webpack-plugingets installed with the--no-package-lockflag in the type integration tests. This causeseslint-webpack-pluginto use the same version of@types/estreeas ESLint does, i.e. the latest v1.0.7 instead of v1.0.6 specified inpackage-lock.json.Is there anything you'd like reviewers to focus on?
Does this approach make sense?