Skip to content

feat: normalize patterns to handle "./" prefix in files and ignores - #19568

Merged
mdjermanovic merged 5 commits into
eslint:mainfrom
Pixel998:feat/normalize-patterns
Mar 31, 2025
Merged

mdjermanovic merged 5 commits into
eslint:mainfrom
Pixel998:feat/normalize-patterns

Conversation

@Pixel998

@Pixel998 Pixel998 commented Mar 23, 2025 •

Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Closes #18757

What changes did you make? (Give an overview)

Updated @eslint/config-array to v0.20.0 to include eslint/rewrite#162 and added tests.

Is there anything you'd like reviewers to focus on?

@Pixel998
Pixel998 requested a review from a team as a code owner March 23, 2025 22:08
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Mar 23, 2025
@eslint-github-bot eslint-github-bot Bot added the feature This change adds a new feature to ESLint label Mar 23, 2025
@Pixel998
Pixel998 marked this pull request as draft March 23, 2025 22:08
@netlify

netlify Bot commented Mar 23, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit a39ad77
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67e866272d5f3b00081b0c1f

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Mar 25, 2025
@mdjermanovic

Copy link
Copy Markdown
Member

@eslint/config-array v0.20.0 has been released now.

@mdjermanovic mdjermanovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a few tests to ensure #18757 is fixed?

@Pixel998
Pixel998 marked this pull request as ready for review March 29, 2025 20:24
@Pixel998

Copy link
Copy Markdown
Contributor Author

@mdjermanovic Done. Sorry for the delay.

@snitin315 snitin315 moved this from Needs Triage to Implementing in Triage Mar 31, 2025

@snitin315 snitin315 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Leaving it open for 2nd review.

@snitin315 snitin315 moved this from Implementing to Second Review Needed in Triage Mar 31, 2025

@mdjermanovic mdjermanovic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic
mdjermanovic merged commit 03fb0bc into eslint:main Mar 31, 2025
@github-project-automation github-project-automation Bot moved this from Second Review Needed to Complete in Triage Mar 31, 2025
@Pixel998
Pixel998 deleted the feat/normalize-patterns branch April 16, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool feature This change adds a new feature to ESLint

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Bug: Config array "./src" and "src" aren't treated as the same

3 participants