feat: support TS syntax in no-unused-expressions#19564
Merged
snitin315 merged 18 commits intoeslint:mainfrom Apr 9, 2025
Merged
feat: support TS syntax in no-unused-expressions#19564snitin315 merged 18 commits intoeslint:mainfrom
no-unused-expressions#19564snitin315 merged 18 commits intoeslint:mainfrom
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
19 tasks
4a3e168 to
2f2210c
Compare
2f2210c to
a050c53
Compare
JoshuaKGoldberg
requested changes
Mar 24, 2025
Contributor
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
A great start! 🚀
I found a few areas of code that can be trimmed down or outright removed without causing any unit test failures. The unit tests cover pretty much what typescript-eslint's current tests do, so my hunch is it's all dead code. But, were there other cases you wanted to cover with the extra code?
2abed4a to
532a759
Compare
JoshuaKGoldberg
requested changes
Mar 25, 2025
Contributor
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
A little bit more to remove, but I think this is getting there 🙂
snitin315
reviewed
Mar 26, 2025
snitin315
reviewed
Mar 26, 2025
SwetaTanwar
commented
Mar 29, 2025
snitin315
previously approved these changes
Mar 31, 2025
Contributor
snitin315
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution ❤️
Leaving it open for @mdjermanovic
JoshuaKGoldberg
requested changes
Mar 31, 2025
Contributor
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
SO much code deletion, awesome! What a great simplification. 👏
Just one last thing from me, I think, for clarifying docs a bit.
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
snitin315
previously approved these changes
Mar 31, 2025
mdjermanovic
reviewed
Apr 1, 2025
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
no-unused-expressions
mdjermanovic
reviewed
Apr 1, 2025
mdjermanovic
approved these changes
Apr 9, 2025
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @JoshuaKGoldberg and @snitin315 to verify.
snitin315
approved these changes
Apr 9, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Related to #19173
Made current eslint/no-unused-expressions typescript syntax aware as per @typescript-eslint/no-unused-expressions
Is there anything you'd like reviewers to focus on?